Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add timepicker component #299
base: main
Are you sure you want to change the base?
feat: Add timepicker component #299
Changes from 58 commits
7c87efd
61655a6
180fa74
11e53cd
9c2984b
debbadf
e080e1d
ea419ca
6eeac0a
8728221
4a72a08
d7523d3
6fc2a14
5200b0c
300f3bd
5ff39dd
69a994f
9d30222
83e7732
1860d51
68087b2
f915cd8
f32c890
314db02
d738613
ad8bd29
c8a653e
4b67bee
99e7581
22df52c
94aaf53
056f1ad
ba39e73
dd82d28
04b0170
b7c03c5
0e744d1
7196d40
593bf51
0d8150d
52be878
bb9d0df
3010c06
446c530
26dc9c2
c2d1736
86864e5
666b1bb
54bcf0a
56c4a16
286b536
3000eb1
da19cbd
528347f
8793f16
9bf08e3
cb7d011
d906675
b0608e3
3378c01
6bf50b8
50e59e1
fe4c0fe
d605326
0d89669
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be setters and follow function naming e.g.
setInvalid
Plus,
setInvalid
seems like it would do the same thing asinvalid
property, so it's not necessary?note: date picker seems to be doing the naming right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the naming of the setter is fine, i don't think other component (i,e. combobox) use this naming.
setInvalid
is fine but no need for unnecessary changes.In terms of the need of
setInvalid
, please check combobox as well because the setter is similar.