Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit mode for fragment title aligned properly #284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Madhura-saw
Copy link

Related Tickets & Documents

What type of PR is this? (check all that apply)

  • Feature
  • Bug Fix
  • Refactor
  • Documentation Update

Scope

This PR fixes the edit mode of the fragment title where the title does not move down and the also title subheading is not shifted from its original place.

Implementation

Flex properties of title-subheading and fragment-title were changed in order to align everything properly.
No other changes.

Screenshots/Recordings/Diagrams:

Screen.Recording.2023-10-15.at.4.31.58.PM.mp4

How to test

Check the UI by clicking on the edit icon besides the title in new fragment.

[optional] To-do before merge

[optional] To-do after merge

@netlify
Copy link

netlify bot commented Oct 15, 2023

👷 Deploy request for carbon-components-builder pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ce93e0e

@Akshat55
Copy link
Member

@Madhura-saw Could you please sign off your commits? You can do so with the following instrucitons:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~2 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin fix-edit-title

@Madhura-saw
Copy link
Author

@Madhura-saw Could you please sign off your commits? You can do so with the following instrucitons:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~2 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin fix-edit-title

yeah sure

@Madhura-saw
Copy link
Author

I am getting this message when I try to fetch the pull request

Screenshot 2023-10-21 at 1 06 50 PM

Can you help me with this?
I tried searching for this but nothing worked

@zvonimirfras
Copy link
Member

I am getting this message when I try to fetch the pull request
Screenshot 2023-10-21 at 1 06 50 PM

Can you help me with this? I tried searching for this but nothing worked

What are you trying to do? 🤔

@Madhura-saw
Copy link
Author

I am getting this message when I try to fetch the pull request
Screenshot 2023-10-21 at 1 06 50 PM
Can you help me with this? I tried searching for this but nothing worked

What are you trying to do? 🤔

sign off commits

@zvonimirfras
Copy link
Member

I am getting this message when I try to fetch the pull request
Screenshot 2023-10-21 at 1 06 50 PM
Can you help me with this? I tried searching for this but nothing worked

What are you trying to do? 🤔

sign off commits

Here's what git says https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants