-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit mode for fragment title aligned properly #284
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for carbon-components-builder pending review.Visit the deploys page to approve it
|
@Madhura-saw Could you please sign off your commits? You can do so with the following instrucitons:
|
yeah sure |
Here's what git says https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Related Tickets & Documents
What type of PR is this? (check all that apply)
Scope
This PR fixes the edit mode of the fragment title where the title does not move down and the also title subheading is not shifted from its original place.
Implementation
Flex properties of title-subheading and fragment-title were changed in order to align everything properly.
No other changes.
Screenshots/Recordings/Diagrams:
Screen.Recording.2023-10-15.at.4.31.58.PM.mp4
How to test
Check the UI by clicking on the edit icon besides the title in new fragment.
[optional] To-do before merge
[optional] To-do after merge