Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider component #258

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

slider component #258

wants to merge 27 commits into from

Conversation

maxxyouu
Copy link
Contributor

@maxxyouu maxxyouu commented Aug 11, 2023

resolve for #152

Signed-off-by: Max You <[email protected]>
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for carbon-components-builder ready!

Name Link
🔨 Latest commit 5938d55
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-builder/deploys/6657b268a281d00008bf2c2a
😎 Deploy Preview https://deploy-preview-258--carbon-components-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
src/sdk/src/fragment-components/a-component.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/ui-fragment/src/components/ui-slider.tsx Outdated Show resolved Hide resolved
src/ui-fragment/src/components/ui-slider.tsx Outdated Show resolved Hide resolved
src/ui-fragment/src/components/ui-slider.tsx Outdated Show resolved Hide resolved
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/ui-fragment/src/components/ui-slider.tsx Outdated Show resolved Hide resolved
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Text input shouldn't be focusable in the editor.
  • the undefined
image
  • Input should be "Theme", not "Light"
image
  • as a dev, I'm not sure I'd do this here, and I also think it's redundant and you should be able to just pass in the variable as is, and if it's not light, the component will default to dark
image
  • is there a "required" input/prop in both framework that we should add here for use in forms?

@fkuhrt
Copy link

fkuhrt commented Sep 11, 2023

When I set
min=10
value = 20
max = 1000

the slider number for max does not chnage when sliding. It remains 1000.

Warning: Failed prop type: Invalid prop max of type string supplied to Slider, expected number.
Warning: Failed prop type: Invalid prop min of type string supplied to Slider, expected number.
Warning: Failed prop type: Invalid prop value of type string supplied to Slider, expected number.

react-jsx-dev-runtime.development.js:118

Thanks for investigating
@maxxyouu

src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
src/sdk/src/fragment-components/a-slider.tsx Outdated Show resolved Hide resolved
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like package-lock shouldn't be updated

@zvonimirfras zvonimirfras self-requested a review January 4, 2024 21:44
Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock and build seems to error

maxxyouu and others added 2 commits January 10, 2024 16:20
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
@maxxyouu
Copy link
Contributor Author

Verified that the component features and export works.

1 similar comment
@maxxyouu
Copy link
Contributor Author

Verified that the component features and export works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA/Review
Development

Successfully merging this pull request may close these issues.

4 participants