-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slider component #258
base: main
Are you sure you want to change the base?
slider component #258
Conversation
Signed-off-by: Max You <[email protected]>
✅ Deploy Preview for carbon-components-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Text input shouldn't be focusable in the editor.
- the undefined
- Input should be "Theme", not "Light"
- as a dev, I'm not sure I'd do this here, and I also think it's redundant and you should be able to just pass in the variable as is, and if it's not light, the component will default to dark
- is there a "required" input/prop in both framework that we should add here for use in forms?
When I set the slider number for max does not chnage when sliding. It remains 1000. Warning: Failed prop type: Invalid prop react-jsx-dev-runtime.development.js:118 Thanks for investigating |
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like package-lock shouldn't be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock and build seems to error
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Verified that the component features and export works. |
1 similar comment
Verified that the component features and export works. |
Signed-off-by: Akshat Patel <[email protected]>
Signed-off-by: Akshat Patel <[email protected]>
Signed-off-by: Max You <[email protected]>
resolve for #152