Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add slider component #155

Closed
wants to merge 16 commits into from
Closed

feat: Add slider component #155

wants to merge 16 commits into from

Conversation

MoizMasud
Copy link
Contributor

@MoizMasud MoizMasud commented Oct 4, 2022 •
edited
Loading

closes #174
closes #152

@netlify
Copy link

netlify bot commented Oct 4, 2022 •
edited
Loading

👷 Deploy request for carbon-components-builder pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 18fefcd

zvonimirfras
zvonimirfras reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview is failing for some reason 🤔

Looks pretty clean otherwise, but I do want to check the preview once it's fixed.

src/routes/edit/share-options/exports/frameworks/angular-fragment.ts Outdated Show resolved Hide resolved
@MoizMasud MoizMasud marked this pull request as draft October 19, 2022 17:05
@MoizMasud
Lint alittle
9349378 
Signed-off-by: Moiz Masud <[email protected]>
@MoizMasud MoizMasud changed the title Slider Add Slider component Nov 22, 2022
@MoizMasud MoizMasud marked this pull request as ready for review November 23, 2022 19:23
@MoizMasud MoizMasud changed the title Add Slider component feat: Add slider component Nov 29, 2022
@MoizMasud
Copy link
Contributor Author

@Akshat55 please review this next

@MoizMasud MoizMasud mentioned this pull request Feb 7, 2023
Closed
MoizMasud and others added 3 commits February 7, 2023 14:21
@Akshat55 Akshat55 closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras

@Akshat55 Akshat55 Awaiting requested review from Akshat55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Slider component Add otherImports to component for angular
3 participants
@MoizMasud @zvonimirfras @Akshat55