Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded xcodeprojs in workspace #no-public-changes #484

Merged
merged 10 commits into from
May 19, 2017
Merged

Conversation

tbaranes
Copy link
Member

@tbaranes tbaranes commented May 18, 2017

First step for #479

  • No code updates
  • Adding IBAnimatable.xcworkspace
  • Adding two new xcodeproj:
    • IBAnimatable.xcodeproj (framework)
    • IBAnimatableApp.xcodeproj (demo / playground). In a long term process, I'm even wondering if we shouldn't make two demos: one for the full demo, and a second one for playgrounds
  • Reorganising sources: map Xcode groups with finder (I may have broken a few groups orders in Xcode, I will reorganise them if the PR is approved)
  • Updating paths for: travis, danger, cocoapods
  • Move all the framework sources in a directory Sources

One question: I know that, from the beginning, we separate storyboards and codes in the demo app. I'm personally a huge fan of this pattern because I find it hard to navigate, and find back the related files. What do you guys prefers about this? If you are ok to group them, I can update the PR.

I'm targeting master because it doesn't introduce any breaking changes, only internal restructuration, but it will be very hard to rebase any PRs due to these changes 馃槵

@IBAnimatableBot
Copy link

IBAnimatableBot commented May 18, 2017

1 Warning
鈿狅笍 Big PR

Generated by 馃毇 Danger

@SD10
Copy link
Member

SD10 commented May 18, 2017

@tbaranes you mean group each storyboard file with its respective view controller?

I do it both ways depending on the project. I agree that grouping them together would significantly help when working with the demo app. I would vote yes for this change 馃憤

@tbaranes
Copy link
Member Author

That what I mean!

@phimage phimage mentioned this pull request May 18, 2017
1 task
@tbaranes
Copy link
Member Author

I just reordered xcodeproj groups (same as master), I think it's ready to go. My question about the storyboards organisation still here, but we can do it in a second a PR. If travis passes, and everything is ok with it, it's ok to go 馃挜

Copy link
Member

@JakeLin JakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 I think we need to update the README.md as well. open IBAnimatable.xcworkspace

@JakeLin
Copy link
Member

JakeLin commented May 19, 2017

One question: I know that, from the beginning, we separate storyboards and codes in the demo app. I'm personally a huge fan of this pattern because I find it hard to navigate, and find back the related files. What do you guys prefers about this? If you are ok to group them, I can update the PR.

I prefer to group them by features. I don't know why I did it that way (separating storyboards and codes)

@tbaranes tbaranes merged commit 6e0fd1a into master May 19, 2017
@tbaranes tbaranes deleted the feature/workspace branch May 19, 2017 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants