Add tests for PaddingDesignable & fix height bug #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
tbaranes
approved these changes
May 16, 2017
JakeLin
approved these changes
May 16, 2017
SD10
force-pushed
the
testing/padding-designable
branch
from
a81d877
to
91eccb1
Compare
|
No problem! Ran out of time to fix SwiftLint warnings last night 😅 |
|
#434 - marking this for record keeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request:
PaddingDesignableprotocol.Reasoning:
sidesconfiguration was set to the amount of width padding.Therefore, if you provided a width that was greater than the height of the text field, the padding view could possibly extend outside the bounds of the text field.