Optimize access to filter map in find_annotated_strategy
#3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
May 10, 2024
There was a problem hiding this comment.
I'm wondering if it makes sense to use functools.cache on get_constraints_filter_map as well?
It's important to avoid caching the empty-map result, in case the module is imported later, and then cheap enough that it's not worth a fancy only-cache-one-branch system.
| @@ -341,10 +341,11 @@ def find_annotated_strategy(annotated_type): | |||
| return arg | |||
|
|
|||
| filter_conditions = [] | |||
| filter_map = get_constraints_filter_map() | |||
There was a problem hiding this comment.
let's move this inside the if "annotated_types" in sys.modules: below, to save a bit of time in the no-annotated-types case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3980.
I'm wondering if it makes sense to use
functools.cacheonget_constraints_filter_mapas well?