Refactor and improve project structure #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For python projects it is recommended to use a tool like *Poetry* to manage dependencies easily. It allows you to tell user which dependencies are necessary, specify versions... It is a great tool for python and easy to learn following the official doc. I also added .vscode to .gitignore because it is a folder which is different for each programmer, so it should not be pushed
'id' is a keyword in python, so you should avoid using it as a variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python projects it is recommended to use
a tool like Poetry to manage dependencies easily.
It allows you to tell user which dependencies
are necessary, specify versions...
It is a great tool for python and easy to learn
following the official doc.
I also added .vscode to .gitignore because
it is a folder which is different for each
programmer, so it should not be pushed
Another change I made is to make a function
to create the downloads folder, because if it does not
exist, it has to be created