Rename config for docker #176
Conversation
|
This would break the local environment without docker. You might want to use development-docker.json as a filename instead. |
ionphractal
changed the title
|
Hm so we might want to treat |
|
@ionphractal great debugging! Could you use Apart from that 👍 |
config/development.json
Outdated
| "audience": "http://webapp.127.0.0.1.xip.io:3030" | ||
| } | ||
| }, | ||
| "seeder": { |
There was a problem hiding this comment.
And maybe remove seeder part completely. It should be up to the user if he or she wants to seed the database in docker.
docker-compose.override.yml
Outdated
| @@ -4,6 +4,7 @@ services: | |||
| api: | |||
| environment: | |||
| - NODE_ENV=development | |||
| - NODE_APP_INSTANCE=docker | |||
There was a problem hiding this comment.
Not strictly required as it is set in the Dockerfile @ionphractal
While it is important to have it set in the docker container, I would not add it additionally in `docker-compose.yml` because other developer might believe, it is necessary to have it there.
|
@appinteractive I restarted the build once, can you tell me what's wrong with codacy right now? |
|
@roschaefer codacy? |
|
It's failing the build. |
After changing the domains to xip.io, a local Docker development environment was unable to load images (failing with 401 unauthorized). That is because the JWT token audience uri was still set to localhost and hence the token was not recognized as valid.
The configuration package loads the config from NODE_ENV. And as there was no development config and Docker uses "development" I though I'd rename the config and extend it with the required parameters.
Does this break anything on your side? @appinteractive @roschaefer