Remove mailchimp and fix GH deploy actions (#620)

* Remove mailchimp * Fix use of GH variables in our deploy actions --------- Signed-off-by: Carl Gieringer <[email protected]>
Howdju · Nov 8, 2023 · 4ec08f0 · 4ec08f0
1 parent 2248f0e
commit 4ec08f0
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 39 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -31,12 +31,12 @@ jobs:
  - name: Setup Node.JS
  uses: actions/setup-node@v3
  with:
- node-version: $NODE_VERSION
+ node-version: ${{ vars.NODE_VERSION }}
  cache: "yarn"
  - name: Install Yarn
  run: |
  corepack enable
- yarn set version $YARN_VERSION
+ yarn set version ${{ vars.YARN_VERSION }}
  - name: Install dependencies
  run: yarn install
  - name: Lint
@@ -127,12 +127,12 @@ jobs:
  - name: Setup Node.JS
  uses: actions/setup-node@v3
  with:
- node-version: $NODE_VERSION
+ node-version: ${{ vars.NODE_VERSION }}
  cache: "yarn"
  - name: Install Yarn
  run: |
  corepack enable
- yarn set version $YARN_VERSION
+ yarn set version ${{ vars.YARN_VERSION }}
  - name: Install dependencies
  run: yarn install
  - name: Changed-files test coverage

diff --git a/.github/workflows/deploy-preprod.yml b/.github/workflows/deploy-preprod.yml
@@ -45,12 +45,12 @@ jobs:
  - name: Node.js
  uses: actions/setup-node@v3
  with:
- node-version: $NODE_VERSION
+ node-version: ${{ vars.NODE_VERSION }}
  - name: Corepack
  # Enables yarn v2
- run:
+ run: |
  corepack enable
- yarn set version $YARN_VERSION
+ yarn set version ${{ vars.YARN_VERSION }}
  - name: Yarn install
  run: yarn install
  - name: Deploy API

diff --git a/.github/workflows/deploy-prod.yml b/.github/workflows/deploy-prod.yml
@@ -24,12 +24,12 @@ jobs:
  aws-region: ${{ env.AWS_REGION }}
  - uses: actions/setup-node@v3
  with:
- node-version: $NODE_VERSION
+ node-version: ${{ vars.NODE_VERSION }}
  - name: Corepack
  # Enables yarn v2
- run:
+ run: |
  corepack enable
- yarn set version $YARN_VERSION
+ yarn set version ${{ vars.YARN_VERSION }}
  - name: Yarn install
  run: yarn install
  - name: Update API Lambda Alias

diff --git a/.github/workflows/flaky-tests-check.yml b/.github/workflows/flaky-tests-check.yml
@@ -36,12 +36,12 @@ jobs:
  - name: Setup Node.JS
  uses: actions/setup-node@v3
  with:
- node-version: $NODE_VERSION
+ node-version: ${{ vars.NODE_VERSION }}
  cache: "yarn"
  - name: Install Yarn
  run: |
  corepack enable
- yarn set version $YARN_VERSION
+ yarn set version ${{ vars.YARN_VERSION }}
  - name: Install dependencies
  run: yarn install
  - name: Check flaky tests

diff --git a/premiser-ui/src/LoginPage.tsx b/premiser-ui/src/LoginPage.tsx
@@ -142,33 +142,6 @@ class LoginPage extends Component<Props> {
  </form>
  </CardContent>
  </Card>
- <Card>
- <CardContent>
- Howdju 2.0 is currently in private gamma. Enter your email to sign
- up for updates:
- </CardContent>
- <CardContent>
- <form
- action="//howdju.us16.list-manage.com/subscribe/post?u=ccf334287da1fbf7af0904629&amp;id=f08c3a775d"
- method="post"
- target="_blank"
- // https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/noopener
- {...{ rel: "noopener" }}
- >
- <EmailField id="mce-email" name="EMAIL" required />
- <input
- type="hidden"
- name="b_ccf334287da1fbf7af0904629_f08c3a775d"
- tabIndex={-1}
- />
- <CardActions>
- <SolidButton type="submit" name="subscribe">
- Subscribe
- </SolidButton>
- </CardActions>
- </form>
- </CardContent>
- </Card>
  </SingleColumnGrid>
  </Page>
  );