Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.17.6 #92653

Closed
wants to merge 1 commit into from
Closed

go 1.17.6 #92653

wants to merge 1 commit into from

Conversation

jidicula
Copy link
Contributor

@jidicula jidicula commented Jan 6, 2022

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner labels Jan 6, 2022
@iMichka iMichka added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 6, 2022
@Moisan
Copy link
Member

Moisan commented Jan 7, 2022

orgalorg seems to have been retagged. I opened an issue upstream to confirm.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jan 9, 2022
@iMichka iMichka added in progress Stale bot should stay away and removed stale No recent activity labels Jan 9, 2022
@dadrian
Copy link
Contributor

dadrian commented Jan 10, 2022

@Moisan Do we have to wait for orgalorg to respond? Manually auditing the two commits in orgalorg indicates the difference is entirely in the Github Actions workflow YAML, changing the Go version used in CI. In the mean time, anyone on Monterey running go test on a package where tests create subprocesses is experiencing SIGABRTs on a regular basis, so it would be very nice to get this merged.

@iMichka
Copy link
Member

iMichka commented Jan 10, 2022

Here is a PR to fix orgalorg: #92847. Ideally they should respond quickly, checksum changes are a major security concern. As the change looks legit we are going to move forward a little bit quicker ...

@iMichka iMichka added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Jan 11, 2022
@iMichka
Copy link
Member

iMichka commented Jan 11, 2022

I will rebase this soon. Our CI queue is full so we need to prioritise.
I added the skip-recursive-dependents label to skip one level of dependencies, else the job times out after 3 days.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favour of merging this as soon as CI finishes.

@dadrian
Copy link
Contributor

dadrian commented Jan 13, 2022

Is it going to be an issue that the tests seem to have failed on all ARM platforms?

@jidicula
Copy link
Contributor Author

jidicula commented Jan 13, 2022

Failing in 12-arm64

brew fetch --build-from-source --retry leaf
brew fetch --build-from-source --retry lean-cli
brew fetch --build-from-source --retry leaps
brew fetch --build-from-source --retry lefthook
brew fetch --build-from-source --retry lego
brew fetch --build-from-source --retry lf
brew fetch --build-from-source --retry liqoctl
brew fetch --build-from-source --retry logcli
brew test --retry --verbose logcli
brew fetch --build-from-source --retry lunchy-go

@iMichka iMichka removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 15, 2022
@BrewTestBot
Copy link
Member

:shipit: @iMichka has triggered a merge.

@iMichka
Copy link
Member

iMichka commented Jan 17, 2022

Agreed, let's ship this. Most of the errors look unrelated (networking errors). skip-recursive-dependents was not enough to finish the build in 3 day so this is a little bit worrying, but the CI-build-depents-from-source flag maybe overrides that one.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
@jidicula jidicula deleted the bump-go-1.17.6 branch April 12, 2022 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants