Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Parquet represents schemas as trees with a root node, and columns as paths from the root to a leaf.
parquet-go
, the library Dolt uses to export tables as parquet files, usesparquet_go_root
as the default name of the root node, but other names are allowed.Prior to this PR, Dolt was assuming that the parquet file always had a root node named
parquet_go_root
, and would fail if any other name was used. This PR changes the behavior to have Dolt read the name from the file instead.I also added a test that imports a simple parquet file that was not created with
parquet-go
.This is an actual fix for the following issue. Additional information was added, which actually exposes the root issue at hand. It's possible for the db/revision combo to make it to branch control, which expects just the branch name (since the revision is given under "branch"). This adds the proper split, so that we always get the database name.
dolt_status
,dolt_merge_status
, anddolt_constraint_violations_*
tables for doltgresgo-mysql-server
EXPLAIN
andEXPLAIN PLAN
Moving our current implementation of
EXPLAIN
toEXPLAIN PLAN
, and replaceEXPLAIN
with a dummy implementation of MySQL'sEXPLAIN
Looks like this now:
perf here [no-release-notes] bump for time bytes proto dolthub/dolt#8640
select into
statementsOur
SELECT ... INTO ...
statements return empty result set, which produces strange output in thedolt sql
shell.MySQL just returns ok results, so we should too.
discovered in: fix
AS OF
clause panic for certain expressions dolthub/go-mysql-server#2779AS OF
clause panic for certain expressionsWe attempt to parse eval
AS OF
expressions in the builder (because we assume it is going to be a literal), but Subqueries cannot be evaluated until after they have gone through the analyzer.partially addresses: "AS OF" doesn't work with partial commit hashes, trying to improvise this crashes Dolt dolthub/dolt#8635
Certain tools expect a higher version of MySQL.
Currently, the latest stable version of MySQL is 8.4.4, but
8.0.23
is the minimum needed to satisfy mydumper.Additionally, this alters the
version()
method to select directly from the@@version
system variable.related: Make Dolt work with mydumper dolthub/dolt#8592
vitess
explain plan
For debugging purposes, we replaced MySQL's
EXPLAIN
output with our very own.Unfortunately, it is not causing problems, so we must move our syntax into its own thing.
io_threads
andsql_state
as no-opsrelated: Make Dolt work with mydumper dolthub/dolt#8592
This PR adds support for parsing the mariadb table options listed here:
https://mariadb.com/kb/en/create-table/#table-options
They are all no-ops (much like many of the MySQL table options)
related: Make Dolt work with mydumper dolthub/dolt#8592
Closed Issues