Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
dolt_workspace_*
anddolt_diff
system tables for doltgresCertain types are stored out of band (like
TEXT
andBLOB
), so we compare their addresses to test for existence. Consequently, the error message would contain the hash rather than the contents.This PR fixes the formatting to print the prefix.
fixes: Erroneous output with unique constraint on TEXT or TINYTEXT dolthub/dolt#8629
This is primarily to fix issues with:
For the first issue, we did not actually update the longest match counter, and it was therefore being ignored. The variable existed, but it was not being updated. I think this went so long without being caught (even with all of the tests in
enginetests
andbats
) due to how we handle expression folding, where subset entries are completely ignored if a superset already exists.The second issue is somewhat similar to the first, in that we were not checking the permission set when determining whether a new row is actually a subset. If an existing row is a superset, but the permissions are more restrictive than the new row, then it's not an actual superset, since it has more restrictive permissions. This is even in the documentation, so it's a simple mistake of forgetting to add that check to the code itself.
Lastly, the
bats
tests have been updated such that they rely on sockets now, and Windows does not support sockets. This was not caught since most Windows developers have moved to primary development on Doltgres, so this at least allows such developers to run thebats
tests locally again.Sometimes tables can change their hashes despite having no visible changes. The two ways I identified where this can happen are:
If these are the only changes to a table, we shouldn't report it as changed in
dolt status
.These tables can still be staged and report as modified once staged.
Updates
README
to explain how to installmysql
8.4, since the 9.0 innovation release does not include support for themysql_native_password
auth plugin by default.go-mysql-server
Certain tools expect a higher version of MySQL.
Currently, the latest stable version of MySQL is 8.4.4, but
8.0.23
is the minimum needed to satisfy mydumper.Additionally, this alters the
version()
method to select directly from the@@version
system variable.related: Make Dolt work with mydumper dolthub/dolt#8592
mysql
andinformation_schema
databasesfixes: prevent
CREATE DATABASE mysql;
dolthub/dolt#8621information_schema.processlist.state
The
State
column in ourinformation_schema.processlist
table is different than the MySQL implementation because we include progress information. As a result, it is possible to exceed the 64 character limit that the column is defined as.However, thius means deviating from MySQL's definition of the table.
information_schema
uppercase rule doesn't apply toprocesslist
tableSelecting from information schema typically results in all uppercase column names, except for the
information_schema.processlist
table, which follows the non info schema casing (matches the projection).Relevant MySQL Bug: https://bugs.mysql.com/bug.php?id=84456
Closed Issues
CREATE DATABASE mysql;