Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.43.20 #200119

Merged
merged 2 commits into from
Dec 5, 2024
Merged

dolt 1.43.20 #200119

merged 2 commits into from
Dec 5, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 8634: Add pointers for schemas for dolt_workspace_* and dolt_diff system tables for doltgres
  • 8633: Add TLS options in help docs
  • 8632: fix error message for duplicate unique key violation on out of band types
    Certain types are stored out of band (like TEXT and BLOB), so we compare their addresses to test for existence. Consequently, the error message would contain the hash rather than the contents.
    This PR fixes the formatting to print the prefix.
    fixes: Erroneous output with unique constraint on TEXT or TINYTEXT dolthub/dolt#8629
  • 8630: Fixed issues with branch control
    This is primarily to fix issues with:
    • Potential issue with longest matching branch namespace control rules dolthub/dolt#8622
    • Branch-qualified DSN gets different branch permissions dolthub/dolt#8623
      For the first issue, we did not actually update the longest match counter, and it was therefore being ignored. The variable existed, but it was not being updated. I think this went so long without being caught (even with all of the tests in enginetests and bats) due to how we handle expression folding, where subset entries are completely ignored if a superset already exists.
      The second issue is somewhat similar to the first, in that we were not checking the permission set when determining whether a new row is actually a subset. If an existing row is a superset, but the permissions are more restrictive than the new row, then it's not an actual superset, since it has more restrictive permissions. This is even in the documentation, so it's a simple mistake of forgetting to add that check to the code itself.
      Lastly, the bats tests have been updated such that they rely on sockets now, and Windows does not support sockets. This was not caught since most Windows developers have moved to primary development on Doltgres, so this at least allows such developers to run the bats tests locally again.
  • 8624: Update sql status to not report changes for unstaged tables that have changed but not visibly.
    Sometimes tables can change their hashes despite having no visible changes. The two ways I identified where this can happen are:
    • The table has different column tags from the ancestor because it was originally a different table that got renamed.
    • The table stores whether it's in a conflict and stores the hash of the other branch's table and the common ancestor table.
      If these are the only changes to a table, we shouldn't report it as changed in dolt status.
      These tables can still be staged and report as modified once staged.
  • 8619: README updates to explain MySQL 8.4 requirement
    Updates README to explain how to install mysql 8.4, since the 9.0 innovation release does not include support for the mysql_native_password auth plugin by default.

go-mysql-server

  • 2776: bump mysql version
    Certain tools expect a higher version of MySQL.
    Currently, the latest stable version of MySQL is 8.4.4, but 8.0.23 is the minimum needed to satisfy mydumper.
    Additionally, this alters the version() method to select directly from the @@version system variable.
    related: Make Dolt work with mydumper dolthub/dolt#8592
  • 2775: prevent creating and dropping mysql and information_schema databases
    fixes: prevent CREATE DATABASE mysql; dolthub/dolt#8621
  • 2774: insert ignore to enum column truncates data
  • 2765: increase column size for information_schema.processlist.state
    The State column in our information_schema.processlist table is different than the MySQL implementation because we include progress information. As a result, it is possible to exceed the 64 character limit that the column is defined as.
    However, thius means deviating from MySQL's definition of the table.
  • 2764: information_schema uppercase rule doesn't apply to processlist table
    Selecting from information schema typically results in all uppercase column names, except for the information_schema.processlist table, which follows the non info schema casing (matches the projection).
    Relevant MySQL Bug: https://bugs.mysql.com/bug.php?id=84456

Closed Issues

  • 8629: Erroneous output with unique constraint on TEXT or TINYTEXT
  • 8607: Creating two tables with the same schema and database, dropping one of them, and renaming the second table to the dropped table creates an entry in status but not diff
  • 8622: Potential issue with longest matching branch namespace control rules
  • 8621: prevent CREATE DATABASE mysql;
  • 8611: INSERT IGNORE for ENUM should truncate data instead of using the first element

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 5, 2024
@BrewTestBot BrewTestBot enabled auto-merge December 5, 2024 03:43
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit a7fae33 Dec 5, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.43.20 branch December 5, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants