Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doltgres 0.14.0 #197487

Merged
Merged

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Nov 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR fixes the test failure identified in: #197144

Fixes: dolthub/doltgresql#937

The root issue was that recent authentication changes now require the default username and password to be specified.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Nov 12, 2024
@fulghum fulghum force-pushed the fulghum/doltgresql-regression-test branch from 2d39997 to 36a9893 Compare November 12, 2024 20:57
@chenrui333 chenrui333 mentioned this pull request Nov 12, 2024
Changing doltgres regression test to specify default username/password

The default username and password recently changed to better match PostgreSQL's default username.

doltgres: enable debug logging

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the fulghum/doltgresql-regression-test branch from 36a9893 to ba50bf7 Compare November 12, 2024 21:34
@chenrui333 chenrui333 changed the title Fix doltgres regression test: specify default username/password doltgres 0.14.0 Nov 12, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 12, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 12, 2024
@chenrui333
Copy link
Member

chenrui333 commented Nov 12, 2024

@fulghum Thanks a lot!!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 13, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 13, 2024
Merged via the queue into Homebrew:master with commit 11a07c3 Nov 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doltgres 0.14.0 regression test failure
4 participants