Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectral-cli 6.14.0 #197414

Merged
merged 2 commits into from
Nov 13, 2024
Merged

spectral-cli 6.14.0 #197414

merged 2 commits into from
Nov 13, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Nov 12, 2024
@bevanjkay
Copy link
Member

bevanjkay commented Nov 12, 2024

@daeho-ro I see the test result has changed here, have we confirmed that it is intended as a feature and not a regression?

@daeho-ro
Copy link
Member

daeho-ro commented Nov 12, 2024

@bevanjkay ,

Before:

/Users/daeho.ro/Downloads/streetlights-mqtt.yml
  1:1   warning  asyncapi-tags                   AsyncAPI object must have non-empty "tags" array.
  2:6   warning  asyncapi-info-contact           Info object must have "contact" object.                        info
 52:13  warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.  channels.smartylighting/streetlights/1/0/event/{streetlightId}/lighting/measured.publish
 64:15  warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.  channels.smartylighting/streetlights/1/0/action/{streetlightId}/turn/on.subscribe
 75:15  warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.  channels.smartylighting/streetlights/1/0/action/{streetlightId}/turn/off.subscribe
 86:15  warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.  channels.smartylighting/streetlights/1/0/action/{streetlightId}/dim.subscribe

✖ 6 problems (0 errors, 6 warnings, 0 infos, 0 hints)

After:

/Users/daeho.ro/Downloads/streetlights-mqtt.yml
  1:1       warning  asyncapi-tags                   AsyncAPI object must have non-empty "tags" array.
  1:11  information  asyncapi-latest-version         The latest version is not used. You should update to the "3.0.0" version.  asyncapi
  2:6       warning  asyncapi-info-contact           Info object must have "contact" object.                                    info
 52:13      warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.              channels.smartylighting/streetlights/1/0/event/{streetlightId}/lighting/measured.publish
 64:15      warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.              channels.smartylighting/streetlights/1/0/action/{streetlightId}/turn/on.subscribe
 75:15      warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.              channels.smartylighting/streetlights/1/0/action/{streetlightId}/turn/off.subscribe
 86:15      warning  asyncapi-operation-description  Operation "description" must be present and non-empty string.              channels.smartylighting/streetlights/1/0/action/{streetlightId}/dim.subscribe

✖ 7 problems (0 errors, 6 warnings, 1 info, 0 hints)

The info is added and I can't find any release note but document found that states

Info object should contain contact object

and so I thought that is intended.


Oops, I misunderstand. It is by version mismatch.
This is the only difference

  1:11  information  asyncapi-latest-version         The latest version is not used. You should update to the "3.0.0" version.  asyncapi

and where can I check?

@daeho-ro
Copy link
Member

OK, the example is the problem.

> cat streetlights-mqtt.yml
asyncapi: '2.6.0'
info:
  title: Streetlights MQTT API

@daeho-ro
Copy link
Member

Two options,

  • keep the example, add 1 info.
  • change the example, then result should be "No results with a severity of 'error' found!"

Anyway, the test case should be changed.

@daeho-ro
Copy link
Member

There is no harm for use of previous one, so I kept the example, changes the test case.
I hope my attempts are sufficient to explain this changes.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 13, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit f493335 Nov 13, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-spectral-cli-6.14.0 branch November 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants