Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwenhywfar: use patch for -flat_namespace #172006

Merged
merged 1 commit into from
May 17, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 17, 2024

Also make gettext build-only on Linux

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles labels May 17, 2024
@cho-m cho-m force-pushed the gwenhywfar-use-patch-and-gettext branch from 068b9e4 to f08ddc7 Compare May 17, 2024 21:00
* make `gettext` build-only on Linux
* fix build with Xcode 15.3

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m force-pushed the gwenhywfar-use-patch-and-gettext branch from f08ddc7 to 3d15ace Compare May 17, 2024 21:22
@cho-m cho-m marked this pull request as ready for review May 17, 2024 21:22
@p-linnane p-linnane added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 8d452b3 May 17, 2024
29 checks passed
@p-linnane p-linnane deleted the gwenhywfar-use-patch-and-gettext branch May 17, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants