Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runme: update test to turn off gitignore #169868

Merged
merged 1 commit into from Apr 23, 2024

Conversation

sourishkrout
Copy link
Contributor

@sourishkrout sourishkrout commented Apr 23, 2024

This will fix a release issue (reference below) in the runme formula that was introduced as per the comment below.

#169788 (comment)

Thanks for diagnosing this @cho-m!

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Apr 23, 2024
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Apr 23, 2024
@chenrui333
Copy link
Member

@sourishkrout can you update your commit msg as runme: update test to turn off gitignore? Thanks!

@chenrui333 chenrui333 changed the title Turn off gitignore runme: update test to turn off gitignore Apr 23, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 23, 2024
@sourishkrout
Copy link
Contributor Author

sourishkrout commented Apr 23, 2024

runme: update test to turn off gitignore

done, @chenrui333.

@chenrui333 chenrui333 added this pull request to the merge queue Apr 23, 2024
@chenrui333
Copy link
Member

Thanks @sourishkrout!

Merged via the queue into Homebrew:master with commit acefa8f Apr 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants