Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SF100Linux Formula #169771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

superjeng1
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core macos-only Formula depends on macOS labels Apr 22, 2024
Based on v1.14.20.x tag at upstream.
Patched for macOS compatibility.
depends_on :macos
depends_on "pkg-config"

patch :DATA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be submitted upstream

license "GPL-2.0-or-later"

depends_on "libusb"
depends_on :macos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Comment on lines +16 to +17
bin.install "dpcmd"
include.install "ChipInfoDb.dedicfg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no make install?

@superjeng1 superjeng1 closed this Apr 22, 2024
@superjeng1
Copy link
Author

#169525 Is the same thing but for Linux. This patch allows the program to be run on macOS. What should I name this formula?

@superjeng1 superjeng1 reopened this Apr 22, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@SMillerDev
Copy link
Member

#169525 Is the same thing but for Linux. This patch allows the program to be run on macOS. What should I name this formula?

The patch should be submitted to the original project and then we can just make the other PR work on macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants