Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvino 2024.1.0 #169752

Merged
merged 8 commits into from Apr 29, 2024
Merged

openvino 2024.1.0 #169752

merged 8 commits into from Apr 29, 2024

Conversation

artanokhov
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@artanokhov artanokhov force-pushed the openvino-2024.1.0 branch 3 times, most recently from 8c55650 to 61f99eb Compare April 23, 2024 09:30
@artanokhov
Copy link
Contributor Author

@chenrui333 @ZhongRuoyu
Currently we observe
Truncated linkage --test openvino output [46](https://github.com/Homebrew/homebrew-core/actions/runs/8798103438/job/24144603076?pr=169752#step:4:48) Error: Missing libraries: [47](https://github.com/Homebrew/homebrew-core/actions/runs/8798103438/job/24144603076?pr=169752#step:4:49) libze_loader.so.1
but we expect libze_loader.so to be part of the driver that the end user can install on their hardware.
Is there a way to suppress this check for a specific library?

@ZhongRuoyu
Copy link
Member

Is there a way to suppress this check for a specific library?

No, I don't think so; cc @Homebrew/core

@SMillerDev
Copy link
Member

but we expect libze_loader.so to be part of the driver that the end user can install on their hardware.
Is there a way to suppress this check for a specific library?

That error suggests that there is a link to it though, so the user MUST install the driver otherwise it does not work.

@artanokhov
Copy link
Contributor Author

but we expect libze_loader.so to be part of the driver that the end user can install on their hardware.
Is there a way to suppress this check for a specific library?

That error suggests that there is a link to it though, so the user MUST install the driver otherwise it does not work.

Yes, that's right, but that's one of the plugins we have.
Thus, the user does not necessarily need to install the NPU driver if, for example, he will only use the CPU plugin.

So, in other words there is no way to suppress such error?
Because in Conda(Conda-Forge) there is possibility to do that via missing_dso_whitelist
https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#whitelisting-shared-libraries

@ZhongRuoyu
Copy link
Member

Is libze_loader.so from https://github.com/oneapi-src/level-zero? If so, does it make sense to make a formula for https://github.com/oneapi-src/level-zero and add a dependency on it?

@artanokhov artanokhov marked this pull request as ready for review April 25, 2024 14:22
@artanokhov
Copy link
Contributor Author

@ZhongRuoyu @chenrui333
Could you please add following labels:
long build
CI-long-timeout
CI-no-fail-fast

@SMillerDev SMillerDev added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 27, 2024
@cho-m cho-m added long build Needs CI-long-timeout and removed CI-long-timeout Use longer GitHub Actions CI timeout. labels Apr 28, 2024
@github-actions github-actions bot added CI-long-timeout Use longer GitHub Actions CI timeout. and removed CI-long-timeout Use longer GitHub Actions CI timeout. labels Apr 28, 2024
@cho-m cho-m added the revision bumps needed Reverse dependencies need to have their revision incremented in the same PR label Apr 28, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 29, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 29, 2024
@ilya-lavrenov
Copy link
Sponsor Contributor

@ZhongRuoyu @chenrui333
is it possible to implement auto-bump of dependencies' revisions? It can be analyzed that one package hardly depends on another and perform auto-bump

@artanokhov
Copy link
Contributor Author

@ZhongRuoyu @chenrui333
As I see currently CI has fallen due to
Error: PR requires the CI-long-timeout label but it is not set! Error: If the longer timeout is not required, remove the "long build" label. Error: Otherwise, add the "CI-long-timeout" label. Error: No more than 2 PRs at a time may use "CI-long-timeout".

Please clarify whether it will be set automatically or will some additional actions be required?

@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Apr 29, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 29, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 29, 2024
Merged via the queue into Homebrew:master with commit 04641b1 Apr 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Needs CI-long-timeout revision bumps needed Reverse dependencies need to have their revision incremented in the same PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants