Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cask avast-secureline-vpn #30923

Merged
merged 3 commits into from Mar 15, 2017
Merged

Add cask avast-secureline-vpn #30923

merged 3 commits into from Mar 15, 2017

Conversation

gtmgianni
Copy link
Contributor

I can't get the uninstall script to show me its arguments (if it has any), and additionally the user needs to restart their system immediately after the uninstall (because the script launches the GUI uninstaller, there is no other option for the user). Also, I included a commit in this pull request which changes the cask avast to avast-mac-security to avoid confusion between the two casks.

@gtmgianni
Copy link
Contributor Author

Additionally, the zap stanza cannot be executed because it always first runs the uninstall sequence, which will either result in the computer having to be restarted after uninstallation, or throwing up an error because the cask is already uninstalled and the uninstaller no longer exists. Either way, the zap stanza is not run.

@gtmgianni
Copy link
Contributor Author

gtmgianni commented Mar 14, 2017

I assume this behaviour is intentional, but if a user runs the zap command and the uninstall stanza fails (for whatever reason), the zap command is not executed afterwards. This issue occurs with the cask trusteer-rapport also, and means it is impossible for me to run the zap command.


pkg 'Avast SecureLine VPN.pkg'

uninstall script: '/Applications/AvastSecureLine.app/Contents/Applications/AvastSecureLineUninstaller.app/Contents/MacOS/AvastSecureLineUninstaller',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wrong use of uninstall script:. Like you mentioned, this is not a script but a GUI. Please remove it. Also see #24377.

@gtmgianni
Copy link
Contributor Author

gtmgianni commented Mar 14, 2017

Actually, don't bother answering my other query @vitorgalvao, I've just realised the reason I'm having issues with zap.
zap is designed to be run instead of uninstall if you want a more thorough uninstallation, right? I've been using zap as a sort of "cleanup" command for cleaning up files after uninstallation, rather than as an "uninstall" command in its own right. Just using zap instead of uninstall fixes the problems I was having with trusteer-rapport and this new cask.

@vitorgalvao vitorgalvao merged commit 79a1ac6 into Homebrew:master Mar 15, 2017
@gtmgianni gtmgianni deleted the avast branch March 15, 2017 20:03
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants