Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little-snitch: update zap #21847

Merged
merged 1 commit into from
Jun 10, 2016
Merged

little-snitch: update zap #21847

merged 1 commit into from
Jun 10, 2016

Conversation

jasmas
Copy link
Contributor

@jasmas jasmas commented Jun 10, 2016

@jasmas
Copy link
Contributor Author

jasmas commented Jun 10, 2016

  • Checked there aren’t open pull requests for the same cask.
  • Checked there aren’t closed issues where that cask was already refused.
  • When naming the cask, followed the token reference.
  • Commit message includes cask’s name.
  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.

@jasmas
Copy link
Contributor Author

jasmas commented Jun 10, 2016

Uninstall for this cask needs some work. We basically need the equivalent of the 'installer manual:' stanza so that when 'brew uninstall little-snitch' completes the user is notified that '/Library/Little Snitch/Little Snitch Uninstaller.app' will need to be run manually and the computer restarted to complete the install.

Please advise the best way to accomplish this?

I thought about writing a script to launch the uninstaller, but as the uninstaller is an interactive application which insists on a shutdown or reboot upon completion, I really think a manual notification to the user is the best course of action here.

@vitorgalvao
Copy link
Member

Well, that’s the problem, we don’t have it.

We’re aware this cask is missing uninstall. We don’t allow any more casks without it, but this one was added before the rule and the app is popular.

Presumably whatever the cask is doing with its uninstallation can be replicated with CLI commands. Issue is we don’t know what the uninstall is really doing. Best way to go about it would be to contact the developers and ask how to perform the uninstallation, or better yet, if they would mind providing a script we could run (it has happened before).

I’ll still merge this PR now since you are still making a useful change, and the cask was already present.

@vitorgalvao vitorgalvao merged commit 3521b92 into Homebrew:master Jun 10, 2016
chizmw pushed a commit to chizmw/homebrew-cask that referenced this pull request Jun 15, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants