Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piezo 1.9.1 #171295

Closed
wants to merge 1 commit into from
Closed

piezo 1.9.1 #171295

wants to merge 1 commit into from

Conversation

samford
Copy link
Member

@samford samford commented Apr 13, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This updates piezo to the latest version, 1.9.1.

This also updates the livecheck block to check the Support Page instead of the Sparkle feed. The Sparkle feed only returns the latest version when an appropriate system value is provided but we're using an old version that 1.9.1 doesn't support. Omitting the system value returns 1.2.2 instead of 1.9.1, so we can't do that. If we use a hardcoded 1441 value (for macOS 14.4.1), we will eventually end up in a situation again where livecheck will always return an older version until we update the system value, so that isn't a sustainable approach.

Our options seem to be to check either the Support Center (https://rogueamoeba.com/support/knowledgebase/?showCategory=Piezo) or the Release Notes
(https://rogueamoeba.com/support/knowledgebase/releasenotes/?product=Piezo) page. The Release Notes are more complete but the download size will grow with each new release, so I've opted for the Support Center page. As with audio-hijack, this isn't ideal but it works and isn't tied to a specific macOS version.

Past that, 1.9.1 requires macOS 14.4 or higher but they haven't updated the application to require Sonoma, so we can't update this to depends_on macos: ">= :sonoma".

This updates `piezo` to the latest version, 1.9.1.

This also updates the `livecheck` block to check the Support Page
instead of the Sparkle feed. The Sparkle feed only returns the latest
version when an appropriate `system` value is provided but we're
using an old version that 1.9.1 doesn't support. Omitting the `system`
value returns 1.2.2 instead of 1.9.1, so we can't do that. If we use
a hardcoded `1441` value (for macOS 14.4.1), we will eventually end
up in a situation again where livecheck will always return an older
version until we update the `system` value, so that isn't a
sustainable approach.

Our options seem to be to check either the Support Center
(https://rogueamoeba.com/support/knowledgebase/?showCategory=Piezo)
or the Release Notes
(https://rogueamoeba.com/support/knowledgebase/releasenotes/?product=Piezo)
page. The Release Notes are more complete but the download size will
grow with each new release, so I've opted for the Support Center page.
This isn't ideal but it works and isn't tied to a specific macOS
version.
@samford samford added the livecheck Issues or PRs related to livecheck label Apr 13, 2024
@krehel
Copy link
Member

krehel commented Apr 13, 2024

Does this PR supersede #169019 @samford?

@samford
Copy link
Member Author

samford commented Apr 13, 2024

Does this PR supersede #169019 @samford?

Whoops, I totally missed that. I'll discuss in that PR (and push commits after we come to an agreement).

@samford samford closed this Apr 13, 2024
@samford samford deleted the piezo-1.9.1 branch April 14, 2024 12:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
livecheck Issues or PRs related to livecheck outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants