Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texstudio: support apple silicon #169292

Merged
merged 4 commits into from Apr 15, 2024

Conversation

zyoshoka
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

#168821

@zyoshoka
Copy link
Contributor Author

@SMillerDev Since app_suffix is defined before version, #{version} will be empty and does not work. I think the workaround is using on_arm.

@daeho-ro
Copy link
Contributor

daeho-ro commented Apr 5, 2024

Someone have to look at this and fix the version order issue.

Copy link
Contributor

@niu541412 niu541412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exchange the orders of 'version' and 'app_suffix' to fix the undefined variable.

Casks/t/texstudio.rb Outdated Show resolved Hide resolved
@bevanjkay
Copy link
Member

I think that given how messy this cask is, using on_{arch} blocks makes most sense.
The arch declaration and on_arch_conditionals are designed to make the file easier to parse, and easier to maintain, which in this case I don't think was achieved by using them.
We should be good to go here now.

@bevanjkay bevanjkay added the ready to merge PR can be merged once CI is green label Apr 15, 2024
@krehel krehel merged commit 65d96e4 into Homebrew:master Apr 15, 2024
9 checks passed
@zyoshoka zyoshoka deleted the texstudio-support-apple-silicon branch April 15, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants