Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickapp-ide 6.6.1 (new cask) #169191

Closed
wants to merge 3 commits into from

Conversation

GaoJuqian
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@chenrui333 chenrui333 changed the title Add quickapp-ide 6.6.1 (new cask) quickapp-ide 6.6.1 (new cask) Mar 15, 2024
@chenrui333
Copy link
Member

@GaoJuqian can you amend your commit msg as quickapp-ide 6.6.1 (new cask)

@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Mar 15, 2024
Casks/q/quickapp-ide.rb Outdated Show resolved Hide resolved
@krehel krehel added awaiting user reply Issue needs response from a user. and removed awaiting maintainer feedback Issue needs response from a maintainer. labels Mar 17, 2024
@krehel
Copy link
Member

krehel commented Mar 18, 2024

Let's get a livecheck from upstream somewhere. Placing a 3rd party artifact into a personal GitHub repository probably isn't an appropriate solution.

@GaoJuqian
Copy link
Author

I got it. I changed it to this.

 homebrew-cask % brew livecheck --debug quickapp-ide
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::NullLoader): loading quickapp-ide
/usr/local/Homebrew/Library/Homebrew/brew.rb (Cask::CaskLoader::FromNameLoader): loading quickapp-ide

Cask:             quickapp-ide
Livecheckable?:   Yes

URL:              https://www.quickapp.cn/api/ide/rpk/getPackage
Strategy:         PageMatch
Regex:            /quickapp-ide-(\d+(?:\.\d+)*)\.pkg/i

Matched Versions:
6.6.1

quickapp-ide: 6.6.0 ==> 6.6.1

Casks/q/quickapp-ide.rb Outdated Show resolved Hide resolved
Casks/q/quickapp-ide.rb Outdated Show resolved Hide resolved
@bevanjkay
Copy link
Member

Can you also confirm whether the name of the .app file that is installed is "quickapp-ide" or just "quickapp"?

@GaoJuqian
Copy link
Author

The pkg files of download pages in version history are all "quickapp-ide". The name of the app after installation is "快应用开发工具.app"

Comment on lines +17 to +20
postflight do
set_ownership "~/.快应用开发工具"
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required, shouldn't this be handled by the pkg installer?

@razvanazamfirei razvanazamfirei added the stale Issue which has not received any feedback for some time. label Apr 18, 2024
@github-actions github-actions bot closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting user reply Issue needs response from a user. new cask stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants