Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHDL 4.1.0 Install #168538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GHDL 4.1.0 Install #168538

wants to merge 1 commit into from

Conversation

TheMDev
Copy link

@TheMDev TheMDev commented Mar 7, 2024

After making any changes to a cask, existing or new, verify:


Hi, After #168502 was merged trying to use GHDL results in the following error:

ghdl:warning: ieee library directory '/usr/local/lib/ghdl/ieee/v08/' not found
ghdl:error: cannot find "std" library

The new version expects the following binary and directories to be linked, whereas the previous version does not. Reverting to 79b16a2 confirms that GHDL 3.0.0 works fine without the binary and directories being linked.

/usr/local/Caskroom/ghdl/4.0.0/bin/ghwdump
/usr/local/Caskroom/ghdl/4.0.0/include/ghdl
/usr/local/Caskroom/ghdl/4.0.0/lib/ghdl

I added a link and unlink step in the postflight, which seems to have resolved the issue.

I am not entirely sure why ghdl is a cask, as it seems it could easily be a formula, If that is the preferred fix, I can create a formula as well.

@dltmtt
Copy link
Contributor

dltmtt commented Mar 7, 2024

Apparently there's already been some discussion on whether GHDL should be a cask or a formula in #46031 and in #79102 if you wanna look into that. As a user I'd expect ghdl to be a formula too, but I haven't looked into the requirements that formulae need to satisfy

@krehel
Copy link
Member

krehel commented Mar 7, 2024

Thanks @TheMDev for the fixes.

Agreed with @MDXZ-delti - was also just posting those links. Historically this seems to have been an issue, though you are welcome to try. I don't know if it's worth the hassle, though.

@TheMDev
Copy link
Author

TheMDev commented Mar 7, 2024

I see... #46031 sheds some light on the requirements for ADA and GCC and why this isn't a formula already. I may look into getting that working, but it seems like quite the undertaking. In the meantime, if we could get this merged and revisit this if I make any progress, that would be great.

@p-linnane p-linnane requested a review from a team March 15, 2024 23:14
@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Mar 15, 2024
Copy link

github-actions bot commented Apr 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Apr 6, 2024
@TheMDev
Copy link
Author

TheMDev commented Apr 7, 2024

I have been working on getting gnat to compile on MacOS 14; however, due to some changes to the compiler and linker in macOS, building gcc gnat is currently not possible. I have been creating a patch to merge upstream in gcc; however, this appears to be quite a challenge. If whoever is maintaining brews gcc or someone knowledgeable in gcc is willing to reach out to get this moving faster, I would be more than happy to work with them to fix this. In the meantime, it would be great to merge this, as a formula is currently unlikely.

For reference, the current issue with building gcc gnat is the libtool.m4 that generates the configure files for gcc incorrectly passes the -single_module flag to the linker, which has been obsolete for over a decade but recently started throwing a warning in MacOS 14 x86 but not aarch64. This results in lt_cv_apple_cc_single_mod being set to no instead of yes. This results in libstdc++.6.dylib-master.o being generated with debugging symbols during the bootstrap process, which results in a bootstrap comparison failure while comparing stages 2 and 3.

@TheMDev TheMDev force-pushed the master branch 2 times, most recently from 1bfd10c to b87a521 Compare April 18, 2024 19:08
@TheMDev TheMDev changed the title Fix GHDL 4.0.0 Install Fix GHDL 4.1.0 Install Apr 18, 2024
@razvanazamfirei razvanazamfirei removed the stale Issue which has not received any feedback for some time. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer feedback Issue needs response from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants