Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starnet2 02,2023 (new cask) #167535

Merged
merged 2 commits into from Apr 4, 2024
Merged

starnet2 02,2023 (new cask) #167535

merged 2 commits into from Apr 4, 2024

Conversation

audibleblink
Copy link
Contributor

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Feb 24, 2024
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Feb 24, 2024
@chenrui333 chenrui333 changed the title adds starnet2 starnet2 02,2023 (new cask) Feb 24, 2024
@bevanjkay
Copy link
Member

@audibleblink How does this differ from the existing starnet-plus-plus cask?

@audibleblink
Copy link
Contributor Author

@bevanjkay starnet-plus-plus has a different set of libraries, pytorch vs tensorflow.
the binaries hardcode different library paths and have different ways of being able to configure load paths.
starnet2 is arm64 only.
the installation packages for each tool by the author are presented as different applications.

@bevanjkay
Copy link
Member

@carlocab Any thoughts here, as you reviewed the related starnet++? Thanks.

@audibleblink
Copy link
Contributor Author

happy to make changes if there's any feedback

@razvanazamfirei
Copy link
Member

This, generally, looks fine to me, but I'm not familiar with starnet++, so I'll defer to other.

One note is that the description should probably be updated to meet our guidelines.

@razvanazamfirei razvanazamfirei added the awaiting maintainer feedback Issue needs response from a maintainer. label Mar 24, 2024
@krehel
Copy link
Member

krehel commented Mar 24, 2024

Agreed, I'm ok here as well!

@razvanazamfirei razvanazamfirei added ready to merge PR can be merged once CI is green and removed awaiting maintainer feedback Issue needs response from a maintainer. labels Apr 4, 2024
@bevanjkay bevanjkay merged commit 91239e8 into Homebrew:master Apr 4, 2024
13 checks passed
github-actions bot pushed a commit to MPLew-is/homebrew-vscodium that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new cask ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants