Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed dbeaverlite and dbeaverultimate for more consistency #147032

Merged
merged 1 commit into from May 12, 2023
Merged

renamed dbeaverlite and dbeaverultimate for more consistency #147032

merged 1 commit into from May 12, 2023

Conversation

ridicolos
Copy link
Contributor

@ridicolos ridicolos commented May 11, 2023 •
edited

I renamed the casks of
dbeaverultimate to dbeaver-ultimate and
dbeaverlite to dbeaver-lite.

DBeaver has 4 versions: lite, community, enterprise and ultimate
If you take a look at the output of brew search dbeaver --cask you see, that the naming of these casks are quite inconsistent. Two of these have a dash. Two of these don't.

I'm not sure, if this can be done so easily, because the cask will be removed for some users and they have to reinstall.

Maybe we have to wait for some kind of alias like mentioned in this issue #111512.

@bevanjkay bevanjkay enabled auto-merge (squash) May 12, 2023 01:27
@bevanjkay bevanjkay merged commit ce617ca into Homebrew:master May 12, 2023
13 checks passed
bevanjkay added a commit that referenced this pull request May 12, 2023
@bevanjkay
Revert "renamed dbeaverlite and dbeaverultimate for more consistency (#…
7aae8ea 
…147032)"

This reverts commit ce617ca.
@bevanjkay bevanjkay mentioned this pull request May 12, 2023
Merged
@bevanjkay
Copy link
Member

@ridicolos Sorry, I didn't mean to merge this in yet. We should wait until #111512 is resolved first.

razvanazamfirei pushed a commit that referenced this pull request May 12, 2023
@bevanjkay
Revert "renamed dbeaverlite and dbeaverultimate for more consistency" (…
987337d 
…#147037)

Revert "renamed dbeaverlite and dbeaverultimate for more consistency (#147032)"

This reverts commit ce617ca.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bevanjkay bevanjkay bevanjkay approved these changes

Assignees
No one assigned
Labels
automerge-skip outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ridicolos @bevanjkay @BrewTestBot