Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

tap_migrations: migrate some casks to homebrew/cask #20186

Merged
merged 1 commit into from Apr 27, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 27, 2024

  • brave-browser-beta
  • brave-browser-dev
  • brave-browser-nightly
  • google-chrome-beta
  • google-chrome-canary
  • google-chrome-dev
  • microsoft-edge-beta
  • microsoft-edge-dev

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@cho-m cho-m marked this pull request as draft April 27, 2024 20:28
Includes:
* `brave-browser-beta`
* `brave-browser-dev`
* `brave-browser-nightly`
* `google-chrome-beta`
* `google-chrome-canary`
* `google-chrome-dev`
* `microsoft-edge-beta`
* `microsoft-edge-dev`

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m changed the title casks: migrate to homebrew/cask tap_migrations: migrate some casks to homebrew/cask Apr 27, 2024
@cho-m
Copy link
Member Author

cho-m commented Apr 27, 2024

Depends on Homebrew/homebrew-cask#172349

Also should probably make sure new homebrew/cask Casks are visible over API before merging.

@cho-m cho-m marked this pull request as ready for review April 27, 2024 21:56
@cho-m
Copy link
Member Author

cho-m commented Apr 27, 2024

Available via API:

❯ unset HOMEBREW_NO_INSTALL_FROM_API

❯ brew info google-chrome@canary
==> google-chrome@canary: latest
https://www.google.com/chrome/canary/
Not installed
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/g/[email protected]
==> Name
Google Chrome Canary
==> Description
Web browser
==> Artifacts
Google Chrome Canary.app (App)

@razvanazamfirei razvanazamfirei merged commit 21bd9f7 into master Apr 27, 2024
9 checks passed
@razvanazamfirei razvanazamfirei deleted the chromium-browsers branch April 27, 2024 22:02
machupicchubeta added a commit to machupicchubeta/dotfiles that referenced this pull request Apr 28, 2024
```
$ brew info --cask google-chrome-canary

Warning: Cask homebrew/cask-versions/google-chrome-canary was renamed to google-chrome@canary.
==> google-chrome-canary: latest
https://www.google.com/chrome/canary/
Installed
/opt/homebrew/Caskroom/google-chrome-canary/latest (61.4KB)
==> Name
Google Chrome Canary
==> Description
Web browser
==> Artifacts
Google Chrome Canary.app (App)
```

Refs.
- Homebrew/homebrew-cask-versions#20186
- Homebrew/homebrew-cask#172349
- Homebrew/homebrew-cask#112102
@bartekpacia
Copy link

Hey @razvanazamfirei, where can I learn more about this migration? Thanks in advance!

@razvanazamfirei
Copy link
Member

Thanks @bartekpacia! See here for more details. Briefly, we're going to migrate all non-deprecated casks from this repository to the main repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants