LIBRARY - implement API for Etherpad v1.8.18, add return and nullable types #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thank you for your very useful library! I've been forking it for our own purposes at @graasp 😊
I'd like to contribute back with the following improvements:
prepare
script, so that it can be consumed from JS code as well 🏗️is-url
and use the nativeURL
node object instead (reason is thatis-url
does not accept e.g. docker-local domains such ashttp://etherpad:9001
) and it can be checked without a library 🌍strictuNullChecks: true
👮♀️deprecated
notice tosetPassword
andisPasswordProtected
(they are now absent from the docs) 👴getStats
query 📊 as well ascopyPadWithoutHistory
✂️Somehow I am not able to make the
server error - timeout
pass in the test suite even though nock is appended.delay(100)
on thegetHtml
endpoint for this test, but I think this was an issue already before these changes.Let me know if you'd like additional changes! Feel free to squash the commits as well.
Cheers