Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabset): reset tabset to current tab when first tab is removed #877

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jav7zaid
Copy link

@jav7zaid jav7zaid commented May 9, 2021

Description

Tabset is not resetting back, when first tab is removed.

What are the relevant story cards/tickets? Any additional PRs or other references?

#872
Jira:

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

Before
tabset

After
tabset-new

@netlify
Copy link

netlify bot commented May 9, 2021

Deploy preview for helix-ui ready!

Built with commit 0be08ca

https://deploy-preview-877--helix-ui.netlify.app

@@ -244,6 +244,7 @@ <h2 id="dynamic-tabset">Dynamic Tabset</h2>
<hx-tabset
ref="tabset"
:current-tab="currentTab"
:tabsize="tabSize"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the advantage of to adding a tab size as an attribute? I wonder if the hx-tabset component could/should/can be aware of how many tabs it has.

Side note: tabCount, might be a more descriptive name as "size" might imply "small, medium, large" etc, related to a component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants