Fix incorrect scissor box in h2d.Scene.captureBitmap #1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an issue with the OpenGL driver when using
h2d.Scene.captureBitmap
. When it sets the scissor bounds to the viewport bounds,GlDriver.curTexture
incorrectly refers to the current texture rather than the texture being rendered into, causing the scissor box to potentially use an incorrect position. I will note that the DirectX driver has no problem here because it doesn't need to alter the scissor box if it's rendering to a texture, which the OpenGL driver needs to do.I have fixed this by simply reordering some function calls in
h2d.Scene.captureBitmap
to ensure the correct framebuffer will be set whensetRenderZone
is called.