Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the drawTo function in objects call onAdd on scene-less objects #1056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made the drawTo function in objects call onAdd on scene-less objects #1056

wants to merge 1 commit into from

Conversation

jefvel
Copy link
Contributor

@jefvel jefvel commented Mar 19, 2022

if that's not called, the filter on the object will not be bound to it.

fixes #1055

@jefvel
Made the drawTo function in objects call onAdd on scene-less objects
0b718eb 
if that's not called, the filter on the object will not be bound to it.
@trethaller
Copy link
Contributor

Could there be issues with objects having onAdd called multiple times but not onRemove?

@Yanrishatum
Copy link
Contributor

It could be, depending if Scene does set its own alllocated flag during the drawTo or not. If sync is properly called then it should set the flag, and during dispose() call onRemoved().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drawing objects with drawTo using a mask filter seems to not work
3 participants
@jefvel @trethaller @Yanrishatum