[make] Generate haxelib binary with nekotools boot -c on Mac/Linux
#11653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nekotools boot` is a bit of a hack and some tools that deal with executables on linux can strip away the haxelib bytecode if it is done this way. `nekotools boot -c` will generate a .c file which can then be compiled manually.
Otherwise it doesn't work if haxe isn't already installed, or it might use the wrong version of the standard library
RMSPORTS1902
approved these changes
May 4, 2024
They are now needed for compiling haxelib
RMSPORTS1902
approved these changes
May 4, 2024
RMSPORTS1902
approved these changes
May 4, 2024
RMSPORTS1902
approved these changes
May 4, 2024
RMSPORTS1902
approved these changes
May 4, 2024
For some reason this environment variable isn't working here on Windows
We don't have neko binaries for mac arm64 yet `nekotools boot run.n` was previously also producing an x64 binary
tobil4sk
force-pushed
the
fix/haxelib-binary
branch
from
291d26f
to
7accedd
Compare
It looks like /usr/local/lib is no longer used as a default path in some cases.
|
Since we are building the executable on macos-13 (rather than macos-12) |
|
Should I merge this or do we need to do something else first? |
I don't think there's anything left to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nekotools bootis a bit of a hack because it simply copies the neko exectuable and injects in the neko bytecode. This can cause issues with some tools that deal with executables on Linux/Mac. HaxeFoundation/neko#130 (comment)This started happening on Arch linux, where the bytecode somehow gets stripped away during packaging so haxelib becomes unusable because it is reverted to the regular neko binary. See: #11652.
nekotools boot -cwill instead generate a .c file which can then be compiled manually. I've changed this for Mac and Linux, but for Windows it will continue to usenekotools bootas it is simpler and doesn't cause issues there as far as I'm aware.I'm not sure if this may have packaging implications now that a c compiler is used directly in the make file?