Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tor): add initial tor support support #89

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Jun 15, 2024

It bumps the fedimint version to this commit https://github.com/fedimint/fedimint/tree/54acaa63a45e6bd14e872cdaaf020e8c100d6b33, as Tor MVP support has landed on master, but hasn't been released yet (planned for 0.5.x).

As Harbor mainly uses the Client, we basically need to specifically use the Connector::Tor as an option, through the .with_tor_connector() auxiliary method.

@oleonardolima oleonardolima force-pushed the feat/add-initial-tor-support-support branch from 4fa345f to aad22e1 Compare September 26, 2024 13:36
@oleonardolima oleonardolima changed the title wip(feat): add initial tor support support feat(tor): add initial tor support support Sep 26, 2024
@oleonardolima oleonardolima marked this pull request as ready for review September 26, 2024 13:37
@oleonardolima
Copy link
Contributor Author

@benthecarman @futurepaul I think we could make use of shadow or chutney for testing, but I still need to grasp more about Harbor's project structure and testing.

I also wonder about validations that we could implement, and make use of compile_error! & co macros to make sure it's using the proper connector, and really annoy any user that changes that to clearnet for example, let me know what you think.

@oleonardolima oleonardolima force-pushed the feat/add-initial-tor-support-support branch from aad22e1 to fb4f747 Compare September 26, 2024 14:10
@benthecarman benthecarman force-pushed the feat/add-initial-tor-support-support branch from 0cc9847 to 9991554 Compare October 7, 2024 23:27
@benthecarman
Copy link
Contributor

benthecarman commented Oct 7, 2024

is there a reason you changed the nightly version of rust? seems likes its failing to get that version

seems that is needed for the tor stuff

@benthecarman benthecarman force-pushed the feat/add-initial-tor-support-support branch 5 times, most recently from 4b0d93b to 11b65ff Compare October 7, 2024 23:56
@benthecarman benthecarman force-pushed the feat/add-initial-tor-support-support branch from 11b65ff to 95a38c0 Compare October 8, 2024 00:05
@benthecarman benthecarman merged commit 1db5ec9 into HarborWallet:master Oct 8, 2024
2 checks passed
@oleonardolima
Copy link
Contributor Author

is there a reason you changed the nightly version of rust? seems likes its failing to get that version

seems that is needed for the tor stuff

IIRC I was trying to fix the Nix environment, and there was some error related to it and the rust version being used.

@oleonardolima oleonardolima deleted the feat/add-initial-tor-support-support branch October 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants