Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Display job arguments #1659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PaulARoy
Copy link
Contributor

@PaulARoy PaulARoy commented May 1, 2020

This derives from the awesome work of @JesseKlauss on this PR: #937

It focuses only on displaying arguments of a job in all lists with a DisplayArgumentsInLists option on DashboardOptions. Set to false by default.

Translations included.

@odinserj
Copy link
Member

odinserj commented May 2, 2020

Hm, this is an interesting feature, but I don't understand how long arguments are displayed here without breaking the whole table? Also, it's possible to include background job arguments by using the DisplayName attribute:

[DisplayName("MyMethod: {0} arg1, {1} arg2")]
public string MyMethod(int arg1, string arg2, string json) {}

So there's a big question regarding this feature.

@PaulARoy
Copy link
Contributor Author

PaulARoy commented May 2, 2020

I honestly didn't know about the display name, but I still think it's an interesting feature to activate for all jobs. As it's not necessarily needed for everyone it's better to deactivate by default, but it's a feature I'd really find relevant for most of my jobs.

The long arguments is indeed an issue. As documentation says, we should keep job arguments as simple as possible, but it still can happen. The fullwidth feature is essential for this to work in my opinion.

But let me work on the long arguments problem; I'll try to find a satisfying solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants