Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon in website docs missing #3720

Open
yochem opened this issue Dec 1, 2024 · 0 comments
Open

Favicon in website docs missing #3720

yochem opened this issue Dec 1, 2024 · 0 comments

Comments

@yochem
Copy link

yochem commented Dec 1, 2024

The current web pages for the docs do not have a icon in the tab bar. This can be fixed in three ways:

  1. Like all pages in the hammerspoon.github.io repo, link to /images/hammerspoon.ico. Pro: easiest. Con: favicon doesn't show in when building docs from this repo.
  2. Copy hammerspoon.ico from the website repo to this repo. Pro: Local docs build includes icon. Con: unnecessary icon in this repo.
  3. Rename /images/hammerspoon.ico in the website repo to /favicon.ico. Browser automatically use favicons in the root of a website if no icon is specified. Pro: expected location. Con: relies on browser.

Let me know which option you like most! I'll submit a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant