Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add MS Teams support for MicMute Spoon #306

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

rshmhrj
Copy link
Contributor

@rshmhrj rshmhrj commented Jul 17, 2023

Hi @dctucker, thanks for creating this awesome tool!
I wanted this functionality to work for MS Teams, so tried to add it in.

  • added code changes to init.lua
  • incremented version to 1.1
  • removed the zip file and regenerated it with make

I used your Zoom if block for reference as well as this geekersdigest article.

The big difference is hs.eventtap.keyStroke({"cmd","shift"}, "m", 0, teams) vs. something like teams:selectMenuItem'Unmute' (which didn't seem to work when I tested it).

It seems to work fine for the most part. In the happy case, MicMute (MM) is muted, and when I join Teams with a large number of people, it automatically starts muted. So toggling off mute works right off the bat.

In other cases, I need to fiddle with one or the other until they are in sync, and I don't know yet how to solve for it:

  • MM is muted, join a Teams meeting with few attendees and mic is on
    • Have to manually toggle the Teams mic to be muted, then MM works
  • MM is un-muted, join a Teams meeting with many attendees and mic is off
    • Have to either:
      • manually toggle the Teams mic to be on, then hit MM to mute both at the same time, OR
      • hit MM to switch MM to muted and Teams mic to be on, then manually hit Teams mic to be muted to sync them

Would be nice to add some logic:

  • to figure out what mute mode the meeting is starting in && to sync it automatically (either MM to Teams, or Teams to MM)
  • to add a config option regarding auto muting on Teams startup behavior:
    • either have MM sync to meeting, OR
    • have MM sync to meeting and automatically set to mute

I hope this PR is a step in the right direction.

@dctucker
Copy link
Contributor

In other cases, I need to fiddle with one or the other until they are in sync

This is my experience in Zoom too. I just always join with audio muted and press my toggle mute hotkey until the application is synchronized with the actual mute status. It's not exactly ideal, but at least it works predictably and reliably without requiring a ton of extra error checking.

@cmsj cmsj merged commit 8dd7400 into Hammerspoon:master Jul 17, 2023
1 check passed
@cmsj
Copy link
Member

cmsj commented Jul 17, 2023

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants