Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Add a broken docstring #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Add a broken docstring #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3edce6d
Add a broken docstring
cmsj Jan 5, 2022
cc8368b
Simplify GH CI now we can emit error messages in-line that get autoco…
cmsj Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 0 additions & 27 deletions .github/workflows/PR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,6 @@ jobs:
cd $GITHUB_WORKSPACE/hammerspoon
/usr/bin/python3 -m pip install -r requirements.txt

# If this is a PR, capture its number
- name: Capture PR number
if: github.event_name == 'pull_request'
run: echo ${GITHUB_REF} | awk 'BEGIN { FS = "/" } ; { print $3 }' >pr_num.txt
- name: Upload PR number
if: github.event_name == 'pull_request'
uses: actions/upload-artifact@v2
with:
name: pr_num.txt
path: pr_num.txt

# Find files modified by this PR
- uses: lots0logs/[email protected]
with:
Expand All @@ -74,22 +63,6 @@ jobs:
- name: Docstrings Linter
run: ./gh_actions_doclint.sh

# Store docstrings linter annotations as an artifact
- name: Upload linter artifacts
if: always()
uses: actions/upload-artifact@v2
with:
name: annotations.json
path: annotations.json

# NOTE: This will fail on third party PRs, until https://github.com/yuzutech/annotations-action/issues/23 is implemented
#- name: Publish Docstring Annotations
# uses: yuzutech/[email protected]
# with:
# repo-token: "${{ secrets.GITHUB_TOKEN }}"
# title: "Docstrings linter"
# input: annotations.json

# Fail CI run if docstrings failed
- name: Check for docstring lint failures
run: ./gh_actions_doclint.sh -v
Expand Down
86 changes: 0 additions & 86 deletions .github/workflows/PR_results.yml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions Source/Seal.spoon/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ obj.plugin_search_paths = { hs.configdir .. "/seal_plugins", obj.spoonPath }
--- Seal:refreshCommandsForPlugin(plugin_name)
--- Method
--- Refresh the list of commands provided by the given plugin.
--- This ought to generate a lint error
---
--- Parameters:
--- * plugin_name - the name of the plugin. Should be the name as passed to `loadPlugins()` or `loadPluginFromFile`.
Expand Down