Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented customization of the size of the cheatsheet and order of … #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmgerman
Copy link

@dmgerman dmgerman commented Dec 19, 2021

I find ModalMgr to be an amazing spoon. but it has some usability problems:

  1. The window is too wide. I frequently have to rotate my head to be able to read all the options
  2. The ordering makes it difficult to find items. One has to go left-right-left-right to read the options
  3. the size of the window is hardcoded. it is too wide, this means my eyes have to move to read the options.

I have added customization. Basically these variables:

-- customize width and height of Cheatsheet
obj.width_factor = 0.30
obj.height_factor = 0.30
-- minimum sizes
obj.min_width = 200
obj.min_height = 200

-- alighment for right column
obj.alignmentRightColumn = 'right'
obj.fillByRow = false
  • The "factor" is the width of the window with respect to the current screen.
  • the "min" is the minimum size of the window to use
  • the alignment for the right column. Allows to change it
  • whether to fill the window by Row or by column. if true it will fill rows first. if false, it will fill columns first. I think by column is easier to read.

One extra advantage of these changes is that each ModalMgr window can have different sizes or filling strategies.

@cmsj
Copy link
Member

cmsj commented Jan 5, 2022

ping @ashfinal as author of ModalMgr

@dmgerman
Copy link
Author

dmgerman commented Jan 5, 2022

I am sorry, I don't know if there is anything I should do to have the checks passed.

@cmsj
Copy link
Member

cmsj commented Jan 14, 2022

I am sorry, I don't know if there is anything I should do to have the checks passed.

Annoyingly GitHub makes it extremely difficult to run checks when third parties submit PRs and still be able to report useful results. Please ignore the failing checks.

@dmgerman
Copy link
Author

dmgerman commented Jun 5, 2023

I have rebased the pull request. Is there anything else that I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants