Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selinux once and for all #4

Open
wants to merge 2 commits into
base: halium-7.1
Choose a base branch
from

Conversation

mariogrip
Copy link
Member

We dont use selinux, it only causes problems, so let's disable it.

Change-Id: I31bc39e1960978e92c4a856aacb026ed95b0fb0a

mariogrip added 2 commits July 3, 2017 22:38
We dont use selinux, it only causes problems, so let's disable it.

Change-Id: I31bc39e1960978e92c4a856aacb026ed95b0fb0a
…elinux

Change-Id: I522dc6c27fdbc52ceb8e2b1dc85edfd854ebf837
@bhush9
Copy link
Member

bhush9 commented Jul 5, 2017

Looks good to me, if you have build and run tested it, feel free to merge.

@bhush9
Copy link
Member

bhush9 commented Jul 5, 2017

And oh well.. there are conflicts.. pls2fix.

@bhush9
Copy link
Member

bhush9 commented Oct 4, 2017

Bump @mariogrip

@mariogrip
Copy link
Member Author

I just tested it, and still works. there is no conflicts now

@mariogrip
Copy link
Member Author

Also removal of /system/sepolicy is needed in order for this to work

@mariogrip
Copy link
Member Author

Should we merge?

@walidham
Copy link

walidham commented Feb 15, 2018

When apply patch got this error
[ 10.314161] 10.314161,3] init: Failed to initialize property area

This error is generated in function property_init in system_properties.cpp (system/core/init)

@fredldotme
Copy link

I'm totally for merging this, this is currently required for suzu (Sony Xperia X) to succeed in building.
As a side note I'd like to add that seccomp policies shouldn't be much of a concern and should be shipped when the defaults include them.

@fredldotme
Copy link

Taking another look at the build result, applying this patch makes things worse.
Init fails to start services due to missing SELinux context definition.
We probably won't be able to get rid of SELinux completely,
especially when Android code heavily relies on it's existance, from build to runtime,
but certain aspects could be fixed by forking and stubbing out where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants