Bugfix - High priority issuses #544

v-stamenova · 2024-09-18T07:36:38Z

Description

Issues that should be fixed here:

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

What needs to be tested

Everything listed above

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

…elled after publishing programme

github-actions · 2024-09-18T07:38:37Z

Coverage report for commit: 229e624
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 71.2%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.8%
  20% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.9%
  30% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.8%
  40% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  70% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.4%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.4%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.4%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.2%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution

Summary - Lines: 27.95% | Methods: 23.46%

Files	Lines	Methods	Branches
app/Actions/Fortify
CreateNewUser.php	90.24%	25.00%	100.00%
PasswordValidationRules.php	100.00%	100.00%	100.00%
ResetUserPassword.php	100.00%	100.00%	100.00%
UpdateUserPassword.php	100.00%	100.00%	100.00%
UpdateUserProfileInformation.php	72.73%	50.00%	100.00%
app/Actions/Jetstream
DeleteUser.php	100.00%	100.00%	100.00%
app/Actions/Log
ApprovalHandler.php	95.83%	50.00%	100.00%
app/Actions/Permissions
ReadPermissionConfig.php	100.00%	100.00%	100.00%
app/Actions/Schedule
PresentationAllocationHelper.php	-	-	100.00%
PresentationConflictChecker.php	-	-	100.00%
ResetSchedule.php	-	-	100.00%
app/Console/Commands
AddSpeakerToPresentation.php	-	-	100.00%
AddToHz.php	-	-	100.00%
ApproveLastCreatedCompany.php	-	-	100.00%
ConfirmAllEmails.php	-	-	100.00%
CreateAdmin.php	7.69%	33.33%	100.00%
ModifyTimeslotDuration.php	-	-	100.00%
SyncPermissions.php	96.77%	85.71%	100.00%
UpsertMasterData.php	73.91%	40.00%	100.00%
app/Events
FinalProgrammeReleased.php	-	-	100.00%
app/Http/Controllers
CompanyController.php	-	-	100.00%
Controller.php	100.00%	100.00%	100.00%
FrequentQuestionController.php	-	-	100.00%
HomeController.php	100.00%	100.00%	100.00%
InvitationController.php	-	-	100.00%
PresentationController.php	-	-	100.00%
ProgrammeController.php	-	-	100.00%
RegistrationController.php	25.00%	-	100.00%
SpeakerController.php	-	-	100.00%
app/Http/Controllers/Crew
BoothController.php	60.42%	66.67%	100.00%
CompanyController.php	96.81%	75.00%	100.00%
CrewController.php	-	-	100.00%
DefaultPresentationController.php	100.00%	100.00%	100.00%
EditionController.php	-	-	100.00%
FrequentQuestionController.php	-	-	100.00%
PresentationController.php	87.27%	66.67%	100.00%
RoomController.php	88.00%	80.00%	100.00%
ScheduleController.php	-	-	100.00%
SponsorshipController.php	94.74%	66.67%	100.00%
UserController.php	-	-	100.00%
app/Http/Controllers/Hub
CompanyController.php	-	-	100.00%
ParticipantController.php	-	-	100.00%
app/Http/Livewire
AuthNavigationMenu.php	-	-	100.00%
DownloadPresentation.php	-	-	100.00%
EmailNotificationPreference.php	-	-	100.00%
GuestNavigationMenu.php	-	-	100.00%
OverrideDifficulty.php	-	-	100.00%
ReleaseFinalProgramme.php	-	-	100.00%
RoomAndTimeslotSelector.php	-	-	100.00%
ShowNotification.php	-	-	100.00%
app/Http/Livewire/Booths
DeleteBoothForm.php	-	-	100.00%
EditBoothModal.php	-	-	100.00%
app/Http/Livewire/Companies
DeleteCompanyForm.php	-	-	100.00%
app/Http/Livewire/DefaultPresentations
EditDefaultPresentationForm.php	-	-	100.00%
app/Http/Livewire/Presentations
DeletePresentationForm.php	-	-	100.00%
EditPresentationModal.php	-	-	100.00%
app/Http/Livewire/Rooms
DeleteRoomForm.php	-	-	100.00%
app/Http/Livewire/Schedule
AddTimeslotPadding.php	-	-	100.00%
RemovePresentationFromSchedule.php	-	-	100.00%
ReplacePresentation.php	-	-	100.00%
ResetTimeslots.php	-	-	100.00%
app/Http/Livewire/Sponsorships
CreateSponsorshipForm.php	-	-	100.00%
DeleteSponsorshipForm.php	-	-	100.00%
app/Http/Livewire/Users
DeleteUserForm.php	-	-	100.00%
app/Http/Middleware
EditionMiddleware.php	33.33%	-	100.00%
app/Http/Requests
StorePresentationRequest.php	100.00%	100.00%	100.00%
app/Listeners
HandleFinalProgrammeReleased.php	-	-	100.00%
app/Livewire
AuthNavigationMenu.php	100.00%	100.00%	100.00%
EmailNotificationPreference.php	-	-	100.00%
GuestNavigationMenu.php	100.00%	100.00%	100.00%
NotificationsList.php	-	-	100.00%
app/Livewire/Booth
CreateBooth.php	14.63%	28.57%	100.00%
DeleteBoothModal.php	-	-	100.00%
EditBoothModal.php	-	-	100.00%
JoinBoothOwnerModal.php	-	-	100.00%
app/Livewire/Company
AddMember.php	-	-	100.00%
BoothRequest.php	-	-	100.00%
DeleteCompany.php	-	-	100.00%
DeleteCompanyModal.php	-	-	100.00%
DetailsForm.php	-	-	100.00%
EditCompanyModal.php	-	-	100.00%
ManageLogo.php	-	-	100.00%
MemberManager.php	-	-	100.00%
RemoveMember.php	-	-	100.00%
SponsorshipRequest.php	-	-	100.00%
UpdateMemberRole.php	-	-	100.00%
app/Livewire/Crew
AssignRoleToUser.php	-	-	100.00%
RevokeRoleOfUser.php	-	-	100.00%
RolePermissionsInfo.php	-	-	100.00%
app/Livewire/Edition
ActivateEditionModal.php	-	-	100.00%
AddKeynoteModal.php	-	-	100.00%
DeleteEditionModal.php	-	-	100.00%
EditEditionModal.php	-	-	100.00%
app/Livewire/EditionEvent
EditEditionEventModal.php	-	-	100.00%
app/Livewire/Forms
BoothForm.php	-	-	100.00%
CompanyForm.php	-	-	100.00%
DefaultPresentationForm.php	-	-	100.00%
EditionEventForm.php	-	-	100.00%
EditionForm.php	-	-	100.00%
FrequentQuestionForm.php	-	-	100.00%
KeynoteForm.php	-	-	100.00%
PresentationForm.php	-	-	100.00%
RoomForm.php	-	-	100.00%
app/Livewire/FrequentQuestions
DeleteFrequentQuestionModal.php	-	-	100.00%
EditFrequentQuestionModal.php	-	-	100.00%
app/Livewire/Presentation
DeletePresentationModal.php	-	-	100.00%
EditPresentationModal.php	-	-	100.00%
JoinAsSpeakerModal.php	-	-	100.00%
UploadPresentation.php	-	-	100.00%
app/Livewire/Registration
CompanyBasicForm.php	8.33%	25.00%	100.00%
CompanyInternshipsForm.php	14.29%	33.33%	100.00%
CompanyLocationForm.php	10.00%	33.33%	100.00%
CompanyMotivationForm.php	16.67%	33.33%	100.00%
CompanyRepresentativeForm.php	7.69%	33.33%	100.00%
ParentComponent.php	2.44%	25.00%	100.00%
SelectCountryCode.php	25.00%	28.57%	100.00%
app/Livewire/Room
DeleteRoomModal.php	-	-	100.00%
EditRoomModal.php	-	-	100.00%
app/Livewire/Schedule
AddDefaultPresentation.php	-	-	100.00%
Cell.php	-	-	100.00%
ConfirmResetScheduleModal.php	-	-	100.00%
DefaultPresentation.php	-	-	100.00%
EditDefaultPresentationModal.php	-	-	100.00%
GridParentComponent.php	-	-	100.00%
Presentation.php	-	-	100.00%
PresentationModal.php	-	-	100.00%
PublishProgrammeButton.php	-	-	100.00%
PublishProgrammeModal.php	-	-	100.00%
app/Livewire/Sponsorship
DeleteSponsorshipModal.php	-	-	100.00%
app/Livewire/Users
UserFilteringList.php	-	-	100.00%
app/Mail
BoothApprovedMailable.php	100.00%	100.00%	100.00%
BoothDisapprovedMailable.php	-	-	100.00%
CancelledPresentationMailable.php	-	-	100.00%
CompanyApprovedMailable.php	100.00%	100.00%	100.00%
CompanyDisapprovedMailable.php	100.00%	100.00%	100.00%
CompanyRepInvitation.php	100.00%	100.00%	100.00%
CustomCompanyInvitation.php	-	-	100.00%
FinalProgrammeReleasedMailable.php	-	-	100.00%
GenericNewUpdatesMailable.php	-	-	100.00%
PresentationApprovedMailable.php	-	-	100.00%
PresentationDisapprovedMailable.php	-	-	100.00%
SponsorshipApprovedMailable.php	100.00%	100.00%	100.00%
SponsorshipDisapprovedMailable.php	100.00%	100.00%	100.00%
UserInvitation.php	-	-	100.00%
app/Models
Booth.php	100.00%	100.00%	100.00%
Company.php	84.51%	72.22%	100.00%
DefaultPresentation.php	-	-	100.00%
Difficulty.php	-	-	100.00%
Edition.php	17.31%	29.41%	100.00%
EditionEvent.php	-	-	100.00%
Event.php	-	-	100.00%
FrequentQuestion.php	100.00%	100.00%	100.00%
InternshipAttribute.php	-	-	100.00%
Invitation.php	25.00%	33.33%	100.00%
Presentation.php	58.75%	68.42%	100.00%
Room.php	100.00%	100.00%	100.00%
Sponsorship.php	37.50%	28.57%	100.00%
Table truncated to fit comment

_{🤖 comment via lucassabreu/comment-coverage-clover}

…ion already scheduled in the room

… select a booth owner

…om/HZ-HBO-ICT/it-conference into bugfix/high-priority-small-issuses

…ompany create

v-stamenova added 3 commits September 16, 2024 21:27

Make the invitation routes unprotected (as in not auth required)

cd9542f

Make sure that the canceled presentations are marked in red when canc…

aa24cf1

…elled after publishing programme

Add colors of presentations in crew schedule to safelist

d70902c

v-stamenova added 7 commits September 18, 2024 10:00

Show speakers and presentations before programme release

aad09ff

Sponsors block on welcome page visible only when such sponsors exist

bcceade

Fix postcode issue on company registration

caf8978

Remove pending booth owner/speaker from assign crew roles

75d1447

Restrict the room deletion to not be possible if there is a presentat…

c58163f

…ion already scheduled in the room

Replace the booth create page with a livewire component to be able to…

eb915d2

… select a booth owner

Fix lint and unit tests

ae3e441

v-stamenova requested review from IGORnvk and TimKardol September 18, 2024 15:02

v-stamenova self-assigned this Sep 18, 2024

v-stamenova added the bugfix label Sep 18, 2024

v-stamenova and others added 3 commits September 18, 2024 17:08

Comment out tests on unused route in BoothController

1932756

Restrict access to programme if it is not released

dfa8084

Fix dark mode styling on companies page

f27035f

v-stamenova marked this pull request as ready for review September 23, 2024 08:29

v-stamenova added 2 commits September 25, 2024 09:10

Fix the http to be https in the links

b6e2592

Merge branch 'bugfix/high-priority-small-issuses' of https://github.c…

2bbbe72

…om/HZ-HBO-ICT/it-conference into bugfix/high-priority-small-issuses

v-stamenova linked an issue Sep 25, 2024 that may be closed by this pull request

Company website link #546

Closed

v-stamenova and others added 6 commits September 25, 2024 09:18

Remove the https and make sure that the seeded data has it instead

c3332b8

Remove the "booth" mistake from the presentation logging

430cfb9

Put a bit more explanation on the select representative in the crew c…

7f443b8

…ompany create

Fix condition in show method for presentation

543f7d1

Fix order of instructions in README

e03a043

Fix wording in emails

229e624

This was linked to issues Sep 25, 2024

Fix README file #536

Closed

Bug: Change wording in email #534

Closed

TimKardol approved these changes Sep 27, 2024

View reviewed changes

TimKardol merged commit 42f5d38 into development Sep 27, 2024
2 checks passed

v-stamenova mentioned this pull request Oct 16, 2024

Feature - Add participant to company #553

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix - High priority issuses #544

Bugfix - High priority issuses #544

v-stamenova commented Sep 18, 2024 •

edited by IGORnvk

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

Bugfix - High priority issuses #544

Bugfix - High priority issuses #544

Conversation

v-stamenova commented Sep 18, 2024 • edited by IGORnvk Loading

Description

Type of change

What needs to be tested

Checklist:

github-actions bot commented Sep 18, 2024 • edited Loading

v-stamenova commented Sep 18, 2024 •

edited by IGORnvk

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading