Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Burst and Burst Premium #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rlankhorst
Copy link

No description provided.

@rlankhorst
Copy link
Author

split into free & premium, and moved it to the correct letter file (didn't notice that before!)

@rviscomi rviscomi changed the title moved to correct letter file, and split into premium & free Split Burst and Burst Premium Jan 9, 2024
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some example URLs of sites with both technologies for testing?

Comment on lines 2686 to 2688
"pricing": [
"free"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here for the list of valid values. If everything that matches this detection is free then I think we can just remove pricing all together, otherwise if Premium matches this too we should use freemium.

Though to be fair HTTP Archive doesn't use these fields and it's more about conforming to the old (public) Wappalyzer convention.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've dropped the pricing part. Currently it's set up to only match free, and pro has it's own entry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example URLs:

https://complianz.io uses premium (burst-pro)
https://www.ikbeneenkameleon.nl/ uses the free version (burst-statistics)

@tunetheweb tunetheweb requested a review from rviscomi May 7, 2024 17:35
@max-ostapenko
Copy link

@rlankhorst You can define versions using the tags feature.
No need for a duplicate.

@max-ostapenko
Copy link

max-ostapenko commented Nov 13, 2024

@rlankhorst please deduplicate the technology entries and add a few detection test sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants