Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise readme and platform docs [skip ci] #3054

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

3gf8jv4dv
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv commented May 18, 2024

Judging from past commits, different maintainers/contributors and different eras have different typesetting styles. This PR tries to unify this.

Except for parentheses, all other symbols have been unified to full-width in the Simplified Chinese variant.

@3gf8jv4dv 3gf8jv4dv marked this pull request as ready for review May 18, 2024 02:14
PLATFORM.md Show resolved Hide resolved
@3gf8jv4dv 3gf8jv4dv requested a review from burningtnt May 18, 2024 03:03
@burningtnt burningtnt requested a review from zkitefly May 18, 2024 03:14
@zkitefly
Copy link
Member

#1929 (comment)

🤔

@burningtnt
Copy link
Member

因为IDE普遍不能将中文标点识别为断句符号,在按词汇移动光标时不能按句子跳。

IJ 里根本就没有一个功能叫做“移动到句尾”

@3gf8jv4dv
Copy link
Contributor Author

#1929 (comment)

🤔

My personal opinion on this: Document is mainly for human reading, also, it is not mathematics-related information. Under these conditions, it is important to maintain the general standards of grammar and typesetting.

At present, many publishing houses and documents that I have personally seen that focus on typesetting generally adopt mainland-related standards (such as full-width symbols).

Considering the launcher’s large Chinese audience, this is more in line with their habits.

In this PR, parentheses are an exception. This is a reference to Apple’s approach.

@burningtnt
Copy link
Member

#1929 (comment)
🤔

My personal opinion on this: Document is mainly for human reading, also, it is not mathematics-related information. Under these conditions, it is important to maintain the general standards of grammar and typesetting.

At present, many publishing houses and documents that I have personally seen that focus on typesetting generally adopt mainland-related standards (such as full-width symbols).

Considering the launcher’s large Chinese audience, this is more in line with their habits.

In this PR, parentheses are an exception. This is a reference to Apple’s approach.

I agree with you.

@3gf8jv4dv 3gf8jv4dv force-pushed the docs-revision branch 3 times, most recently from 7d0564a to ecbba53 Compare May 31, 2024 15:43
@3gf8jv4dv
Copy link
Contributor Author

Any plans to merge this PR?

@burningtnt
Copy link
Member

Merging this PR request writing permission to HMCL-dev/HMCL repository. However, by now, only @Glavo has had this permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants