-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the Delete feat in join us - Admin #831
base: main
Are you sure you want to change the base?
Conversation
Thank you and congrats🎉 for opening this pull request!💖 Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀 |
Add a screen recording of the changes you made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please share a screen recording showing the delete api call in the network tab, so that I can confirm the functionality. Also, please make sure you maintain the responsiveness of the page
@@ -89,3 +88,81 @@ | |||
.button-delete:hover { | |||
background: linear-gradient(45deg, rgb(243, 109, 109), rgb(255, 0, 0)); | |||
} | |||
|
|||
// .dot-loader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[neat] remove the commented code if not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sohail300 Are you working on this pull request??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I was able to pull your changes and test it on my local. There are few comments -
- The deletion is happening but the ui isn't refreshing i.e the deleted card is still appearing on the page
- The UI seems off, please fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI styling needs to be addressed.
Issue that this pull request solves
Closes: #790
Proposed changes
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots