Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the Delete feat in join us - Admin #831

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sohail300
Copy link

@sohail300 sohail300 commented Jan 13, 2024

Issue that this pull request solves

Closes: #790

Proposed changes

  • The join Us cards under the admin panel should not have the URL button as it doesn't seem to require
  • The LinkedIn text should open the linkedIn url in a new Page
  • The delete button should call the delete api with proper toast message

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] My changes does not break the current system and it passes all the current test cases.

Screenshots

image

Copy link

welcome bot commented Jan 13, 2024

Thank you and congrats🎉 for opening this pull request!💖

Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@thevirengarg thevirengarg added Swoc level1 Wiki or Major Documentation work. labels Jan 16, 2024
@thevirengarg
Copy link
Collaborator

Add a screen recording of the changes you made

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please share a screen recording showing the delete api call in the network tab, so that I can confirm the functionality. Also, please make sure you maintain the responsiveness of the page

@@ -89,3 +88,81 @@
.button-delete:hover {
background: linear-gradient(45deg, rgb(243, 109, 109), rgb(255, 0, 0));
}

// .dot-loader {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[neat] remove the commented code if not required

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. and removed level1 Wiki or Major Documentation work. labels Jan 16, 2024
Copy link
Collaborator

@thevirengarg thevirengarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sohail300 Are you working on this pull request??

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I was able to pull your changes and test it on my local. There are few comments -

  1. The deletion is happening but the ui isn't refreshing i.e the deleted card is still appearing on the page
  2. The UI seems off, please fix it.

@Kajol-Kumari Kajol-Kumari added the gssoc GSSoC'24 Label label Jan 20, 2024
Copy link
Collaborator

@Aditi-Dahiya Aditi-Dahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI styling needs to be addressed.

@Kajol-Kumari Kajol-Kumari added the Inactive PR hasn't been updated since long time! label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label Inactive PR hasn't been updated since long time! level2 Bug fixing, adding small features. Swoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Join US Enhancements
4 participants