[simplebar-vue] fix: move vue-demi to dependencies #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I would like to apologise for breaking the
1.7.0
build :/I've trusted unit testing and forgot to install it externally to ensure it works in real life, or should have asked you to release it as beta.
simplebar/packages/simplebar-vue/utils.js
Lines 1 to 6 in 3c5cb8d
vue-demi
is not only used for testing but also to dynamically create the lifecyle names map for cross-compatiblity with vue 2 and 3vue-demi
to latest version, I was going crazy to make the tests work and thought that vue-demi had something to do with it but I has not.