Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement PromQL set op AND/UNLESS #2839

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

implement AND and UNLESS for PromQL.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2839 (7f78c29) into develop (bd9c2f2) will decrease coverage by 0.42%.
Report is 11 commits behind head on develop.
The diff coverage is 11.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2839      +/-   ##
===========================================
- Coverage    84.78%   84.37%   -0.42%     
===========================================
  Files          734      734              
  Lines       114927   115275     +348     
===========================================
- Hits         97440    97262     -178     
- Misses       17487    18013     +526     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Cooool To Me!

src/promql/src/planner.rs Show resolved Hide resolved
src/promql/src/planner.rs Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@killme2008 killme2008 added this pull request to the merge queue Nov 30, 2023
Merged via the queue into GreptimeTeam:develop with commit 9ccd182 Nov 30, 2023
13 checks passed
@waynexia waynexia deleted the promql-set-op branch December 27, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants