feat(mito): Implements compaction scheduler #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/mito2-compact-schedule
branch
from
76e6b77
to
b734dc8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2413 +/- ##
===========================================
+ Coverage 77.60% 77.69% +0.08%
===========================================
Files 718 721 +3
Lines 113634 114015 +381
===========================================
+ Hits 88191 88586 +395
+ Misses 25443 25429 -14 |
40 tasks
fengjiachun
approved these changes
Sep 16, 2023
Co-authored-by: JeremyHi <[email protected]>
killme2008
approved these changes
Sep 17, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: allow multiple waiters in compaction request * feat: compaction status wip * feat: track region status in compaction scheduler * feat: impl compaction scheduler * feat: call compaction scheduler * feat: remove status if nothing to compact * feat: schedule compaction after flush * feat: set compacting to false after compaction finished * refactor: flush status only needs region id and version control * refactor: schedule_compaction don't need region as argument * test: test flush/scheduler for empty requests * test: trigger compaction in test * feat: notify scheduler on truncated * chore: Apply suggestions from code review Co-authored-by: JeremyHi <[email protected]> --------- Co-authored-by: JeremyHi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the compaction scheduler for mito2. The
CompactionSchedulerIt adds some tests for compaction and flush schedulers. I'll add more tests in later PRs.
Other changes
Checklist
Refer to a related PR or issue link (optional)