feat: Implements a reader to make schema compatible #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
evenyag
force-pushed
the
feat/mito2-compat-reader
branch
from
931b600
to
73eacbe
Compare
evenyag
force-pushed
the
feat/mito2-compat-reader
branch
from
73eacbe
to
2a80b38
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2326 +/- ##
========================================================
Coverage ? 77.79%
========================================================
Files ? 712
Lines ? 113969
Branches ? 0
========================================================
Hits ? 88662
Misses ? 25307
Partials ? 0 |
|
@evenyag Some conflicts have to be resolved. |
Merged
via the queue into
GreptimeTeam:migrate-region-server
with commit Sep 7, 2023
a3d1bb7
11 checks passed
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* docs: update comment * feat: Add compat reader to SeqScan * feat: add struct to compat pk and fields * refactor: remove unused fields from ParquetReader * feat: compat framework * feat: Implement CompatPrimaryKey and CompatFields * feat: implement compat reader * feat: Test compat reader * test: test compat reader * feat: add more checks to concat * style: fix clippy * test: more tests for compat reader * test: test reader with projection
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* docs: update comment * feat: Add compat reader to SeqScan * feat: add struct to compat pk and fields * refactor: remove unused fields from ParquetReader * feat: compat framework * feat: Implement CompatPrimaryKey and CompatFields * feat: implement compat reader * feat: Test compat reader * test: test compat reader * feat: add more checks to concat * style: fix clippy * test: more tests for compat reader * test: test reader with projection
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* docs: update comment * feat: Add compat reader to SeqScan * feat: add struct to compat pk and fields * refactor: remove unused fields from ParquetReader * feat: compat framework * feat: Implement CompatPrimaryKey and CompatFields * feat: implement compat reader * feat: Test compat reader * test: test compat reader * feat: add more checks to concat * style: fix clippy * test: more tests for compat reader * test: test reader with projection
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
* docs: update comment * feat: Add compat reader to SeqScan * feat: add struct to compat pk and fields * refactor: remove unused fields from ParquetReader * feat: compat framework * feat: Implement CompatPrimaryKey and CompatFields * feat: implement compat reader * feat: Test compat reader * test: test compat reader * feat: add more checks to concat * style: fix clippy * test: more tests for compat reader * test: test reader with projection
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* docs: update comment * feat: Add compat reader to SeqScan * feat: add struct to compat pk and fields * refactor: remove unused fields from ParquetReader * feat: compat framework * feat: Implement CompatPrimaryKey and CompatFields * feat: implement compat reader * feat: Test compat reader * test: test compat reader * feat: add more checks to concat * style: fix clippy * test: more tests for compat reader * test: test reader with projection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a
CompatReaderto make readers from SSTs with an old schema to be compatible with the latest schema.CompatPrimaryKeyencodes new tags and appends encoded data to the old primary key.CompatFieldsbuilds a mapping from old fields to new fields. For missing columns, it adds a default vector.Checklist
Refer to a related PR or issue link (optional)