-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): Stall write requests and add more flush tests #2322
Merged
evenyag
merged 14 commits into
GreptimeTeam:migrate-region-server
from
evenyag:feat/mito2-stall
Sep 6, 2023
Merged
feat(mito): Stall write requests and add more flush tests #2322
evenyag
merged 14 commits into
GreptimeTeam:migrate-region-server
from
evenyag:feat/mito2-stall
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2322 +/- ##
========================================================
Coverage ? 78.51%
========================================================
Files ? 726
Lines ? 117808
Branches ? 0
========================================================
Hits ? 92494
Misses ? 25314
Partials ? 0 |
fengjiachun
reviewed
Sep 6, 2023
fengjiachun
approved these changes
Sep 6, 2023
2 tasks
v0y4g3r
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
via the queue into
GreptimeTeam:migrate-region-server
with commit Sep 6, 2023
9dc3748
11 checks passed
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: impl reject write * feat: sanitize reject size * feat: add should_stall to WriteBufferManager * feat: stall requests * test: mock WriteBufferManager * feat: add new_with_manager for test and remove object_store from inner * feat: add an event listener for tests * feat: Use listener to test flush * refactor: add flush_test.rs * style: fix clippy * feat: test write stall * test: test flush empty
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: impl reject write * feat: sanitize reject size * feat: add should_stall to WriteBufferManager * feat: stall requests * test: mock WriteBufferManager * feat: add new_with_manager for test and remove object_store from inner * feat: add an event listener for tests * feat: Use listener to test flush * refactor: add flush_test.rs * style: fix clippy * feat: test write stall * test: test flush empty
waynexia
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: impl reject write * feat: sanitize reject size * feat: add should_stall to WriteBufferManager * feat: stall requests * test: mock WriteBufferManager * feat: add new_with_manager for test and remove object_store from inner * feat: add an event listener for tests * feat: Use listener to test flush * refactor: add flush_test.rs * style: fix clippy * feat: test write stall * test: test flush empty
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
…am#2322) * feat: impl reject write * feat: sanitize reject size * feat: add should_stall to WriteBufferManager * feat: stall requests * test: mock WriteBufferManager * feat: add new_with_manager for test and remove object_store from inner * feat: add an event listener for tests * feat: Use listener to test flush * refactor: add flush_test.rs * style: fix clippy * feat: test write stall * test: test flush empty
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…am#2322) * feat: impl reject write * feat: sanitize reject size * feat: add should_stall to WriteBufferManager * feat: stall requests * test: mock WriteBufferManager * feat: add new_with_manager for test and remove object_store from inner * feat: add an event listener for tests * feat: Use listener to test flush * refactor: add flush_test.rs * style: fix clippy * feat: test write stall * test: test flush empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the following feature for flush
reject_write_requests()
should_reject_write()
WriteBufferManager::should_stall()
returns trueStalledRequests
holds stalled write requestshandle_flush_finished()
)It also refactors tests and adds more test cases:
test_util.rs
.column_metadata_to_column_schema()
build_rows()
rows_schema()
delete_rows_schema()
put_rows()
build_rows_for_key()
build_delete_rows_for_key()
delete_rows()
flush_test.rs
.EventListener
to listen to flush and stall events.Checklist
Refer to a related PR or issue link (optional)