Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mito): Integrate access layer and file purger to region #2296

Merged

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Aug 31, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR integrates AccessLayer and FilePurger to each mito region.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review August 31, 2023 11:18
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (migrate-region-server@0c83fb0). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             migrate-region-server    #2296   +/-   ##
========================================================
  Coverage                         ?   78.31%           
========================================================
  Files                            ?      706           
  Lines                            ?   114950           
  Branches                         ?        0           
========================================================
  Hits                             ?    90024           
  Misses                           ?    24926           
  Partials                         ?        0           

src/mito2/src/schedule/scheduler.rs Outdated Show resolved Hide resolved
Co-authored-by: Ruihang Xia <[email protected]>
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Aug 31, 2023
Merged via the queue into GreptimeTeam:migrate-region-server with commit de8cde8 Aug 31, 2023
11 checks passed
@evenyag evenyag mentioned this pull request Aug 31, 2023
2 tasks
waynexia added a commit that referenced this pull request Sep 12, 2023
* feat: alias SchedulerRef and clean scheduler on drop

* feat: add scheduler to workers

* feat: use access layer to read write sst

* feat: add purger to region

* refactor: allow getting region_dir from AccessLayer

* feat: add scheduler to FlushScheduler

* feat: getter for object store

* chore: fix typo

Co-authored-by: Ruihang Xia <[email protected]>

---------

Co-authored-by: Ruihang Xia <[email protected]>
waynexia added a commit that referenced this pull request Sep 12, 2023
* feat: alias SchedulerRef and clean scheduler on drop

* feat: add scheduler to workers

* feat: use access layer to read write sst

* feat: add purger to region

* refactor: allow getting region_dir from AccessLayer

* feat: add scheduler to FlushScheduler

* feat: getter for object store

* chore: fix typo

Co-authored-by: Ruihang Xia <[email protected]>

---------

Co-authored-by: Ruihang Xia <[email protected]>
waynexia added a commit that referenced this pull request Sep 12, 2023
* feat: alias SchedulerRef and clean scheduler on drop

* feat: add scheduler to workers

* feat: use access layer to read write sst

* feat: add purger to region

* refactor: allow getting region_dir from AccessLayer

* feat: add scheduler to FlushScheduler

* feat: getter for object store

* chore: fix typo

Co-authored-by: Ruihang Xia <[email protected]>

---------

Co-authored-by: Ruihang Xia <[email protected]>
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
…eTeam#2296)

* feat: alias SchedulerRef and clean scheduler on drop

* feat: add scheduler to workers

* feat: use access layer to read write sst

* feat: add purger to region

* refactor: allow getting region_dir from AccessLayer

* feat: add scheduler to FlushScheduler

* feat: getter for object store

* chore: fix typo

Co-authored-by: Ruihang Xia <[email protected]>

---------

Co-authored-by: Ruihang Xia <[email protected]>
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…eTeam#2296)

* feat: alias SchedulerRef and clean scheduler on drop

* feat: add scheduler to workers

* feat: use access layer to read write sst

* feat: add purger to region

* refactor: allow getting region_dir from AccessLayer

* feat: add scheduler to FlushScheduler

* feat: getter for object store

* chore: fix typo

Co-authored-by: Ruihang Xia <[email protected]>

---------

Co-authored-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants