-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): Integrate access layer and file purger to region #2296
Merged
fengjiachun
merged 8 commits into
GreptimeTeam:migrate-region-server
from
evenyag:feat/access-layer
Aug 31, 2023
Merged
feat(mito): Integrate access layer and file purger to region #2296
fengjiachun
merged 8 commits into
GreptimeTeam:migrate-region-server
from
evenyag:feat/access-layer
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/access-layer
branch
from
August 31, 2023 11:13
274baa2
to
40d9853
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## migrate-region-server #2296 +/- ##
========================================================
Coverage ? 78.31%
========================================================
Files ? 706
Lines ? 114950
Branches ? 0
========================================================
Hits ? 90024
Misses ? 24926
Partials ? 0 |
waynexia
approved these changes
Aug 31, 2023
Co-authored-by: Ruihang Xia <[email protected]>
fengjiachun
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
via the queue into
GreptimeTeam:migrate-region-server
with commit Aug 31, 2023
de8cde8
11 checks passed
waynexia
added a commit
that referenced
this pull request
Sep 12, 2023
* feat: alias SchedulerRef and clean scheduler on drop * feat: add scheduler to workers * feat: use access layer to read write sst * feat: add purger to region * refactor: allow getting region_dir from AccessLayer * feat: add scheduler to FlushScheduler * feat: getter for object store * chore: fix typo Co-authored-by: Ruihang Xia <[email protected]> --------- Co-authored-by: Ruihang Xia <[email protected]>
waynexia
added a commit
that referenced
this pull request
Sep 12, 2023
* feat: alias SchedulerRef and clean scheduler on drop * feat: add scheduler to workers * feat: use access layer to read write sst * feat: add purger to region * refactor: allow getting region_dir from AccessLayer * feat: add scheduler to FlushScheduler * feat: getter for object store * chore: fix typo Co-authored-by: Ruihang Xia <[email protected]> --------- Co-authored-by: Ruihang Xia <[email protected]>
waynexia
added a commit
that referenced
this pull request
Sep 12, 2023
* feat: alias SchedulerRef and clean scheduler on drop * feat: add scheduler to workers * feat: use access layer to read write sst * feat: add purger to region * refactor: allow getting region_dir from AccessLayer * feat: add scheduler to FlushScheduler * feat: getter for object store * chore: fix typo Co-authored-by: Ruihang Xia <[email protected]> --------- Co-authored-by: Ruihang Xia <[email protected]>
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Sep 13, 2023
…eTeam#2296) * feat: alias SchedulerRef and clean scheduler on drop * feat: add scheduler to workers * feat: use access layer to read write sst * feat: add purger to region * refactor: allow getting region_dir from AccessLayer * feat: add scheduler to FlushScheduler * feat: getter for object store * chore: fix typo Co-authored-by: Ruihang Xia <[email protected]> --------- Co-authored-by: Ruihang Xia <[email protected]>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eTeam#2296) * feat: alias SchedulerRef and clean scheduler on drop * feat: add scheduler to workers * feat: use access layer to read write sst * feat: add purger to region * refactor: allow getting region_dir from AccessLayer * feat: add scheduler to FlushScheduler * feat: getter for object store * chore: fix typo Co-authored-by: Ruihang Xia <[email protected]> --------- Co-authored-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR integrates
AccessLayer
andFilePurger
to each mito region.Checklist
Refer to a related PR or issue link (optional)